Skip to content

Commit ffa731a

Browse files
authored
Merge pull request #37283 from davidgelhar/fix/29825
allow navigating back from SAML signin
2 parents 98129e6 + 2d38101 commit ffa731a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/libs/Navigation/NavigationRoot.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ function parseAndLogRoute(state: NavigationState) {
4545

4646
const focusedRoute = findFocusedRoute(state);
4747

48-
if (focusedRoute?.name !== SCREENS.NOT_FOUND) {
48+
if (focusedRoute?.name !== SCREENS.NOT_FOUND && focusedRoute?.name !== SCREENS.SAML_SIGN_IN) {
4949
updateLastVisitedPath(currentPath);
5050
}
5151

src/pages/signin/SAMLSignInPage/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import type {SAMLSignInPageOnyxProps, SAMLSignInPageProps} from './types';
77

88
function SAMLSignInPage({credentials}: SAMLSignInPageProps) {
99
useEffect(() => {
10-
window.open(`${CONFIG.EXPENSIFY.SAML_URL}?email=${credentials?.login}&referer=${CONFIG.EXPENSIFY.EXPENSIFY_CASH_REFERER}`, '_self');
10+
window.location.replace(`${CONFIG.EXPENSIFY.SAML_URL}?email=${credentials?.login}&referer=${CONFIG.EXPENSIFY.EXPENSIFY_CASH_REFERER}`);
1111
}, [credentials?.login]);
1212

1313
return <SAMLLoadingIndicator />;

0 commit comments

Comments
 (0)