Merge pull request #51814 from Expensify/andrew-hybrid-fixes3

[No QA]Fix iOS production submission and asset uploading

Author: luacmartins

.github/workflows/deploy.yml

@@ -814,7 +814,7 @@ jobs:
           
           # Loop through each file and upload individually (so if one fails, we still have other platforms uploaded)
           for file_entry in "${files[@]}"; do
-            gh release upload "$APP_VERSION" --repo "$GITHUB_REPOSITORY" --clobber "$file_entry"
+            gh release upload ${{ needs.prep.outputs.APP_VERSION }} --repo ${{ github.repository }} --clobber "$file_entry"
           done
         env:
           GITHUB_TOKEN: ${{ github.token }}
@@ -873,7 +873,7 @@ jobs:
           
           # Loop through each file and upload individually (so if one fails, we still have other platforms uploaded)
           for file_entry in "${files[@]}"; do
-            gh release upload "$APP_VERSION" --repo "$GITHUB_REPOSITORY" --clobber "$file_entry"
+            gh release upload ${{ needs.prep.outputs.APP_VERSION }} --repo ${{ github.repository }} --clobber "$file_entry"
           done
         env:
           GITHUB_TOKEN: ${{ github.token }}

fastlane/Appfile

@@ -1,9 +1,11 @@
-app_identifier("com.chat.expensify.chat") # The bundle identifier of your app
-apple_id("[email protected]") # Your Apple email address
-
-itc_team_id("152696") # App Store Connect Team ID
-team_id("368M544MTT") # Developer Portal Team ID
+# See https://docs.fastlane.tools/advanced/Appfile/
+apple_id("[email protected]")
+itc_team_id("152696")
+team_id("368M544MTT")
 
 for_lane :build_hybrid, :build_unsigned_hybrid, :upload_testflight_hybrid do
+  # For HybridApp build tasks, use the OldApp bundle identifier
   app_identifier("com.expensify.expensifylite")
+else
+  app_identifier("com.expensify.expensify")
 end