Merge pull request #22791 from dukenv0307/fix/22085

Fix: Web -Default avatar is changed when we select/unselect a member in Workspace invitation page

Author: Julesssss

src/libs/OptionsListUtils.js

@@ -806,7 +806,7 @@ function getOptions(
         (searchValue !== CONST.EMAIL.CHRONOS || Permissions.canUseChronos(betas))
     ) {
         // Generates an optimistic account ID for new users not yet saved in Onyx
-        const optimisticAccountID = UserUtils.generateAccountID();
+        const optimisticAccountID = UserUtils.generateAccountID(searchValue);
         const personalDetailsExtended = {
             ...personalDetails,
             [optimisticAccountID]: {

src/libs/PersonalDetailsUtils.js

@@ -61,7 +61,7 @@ function getAccountIDsByLogins(logins) {
             const currentDetail = _.find(personalDetails, (detail) => detail.login === login);
             if (!currentDetail) {
                 // generate an account ID because in this case the detail is probably new, so we don't have a real accountID yet
-                foundAccountIDs.push(UserUtils.generateAccountID());
+                foundAccountIDs.push(UserUtils.generateAccountID(login));
             } else {
                 foundAccountIDs.push(Number(currentDetail.accountID));
             }

src/libs/UserUtils.js

@@ -207,13 +207,12 @@ function getSmallSizeAvatar(avatarURL, accountID) {
 }
 
 /**
- * Generate a random accountID.
- * Uses the same approach of 'generateReportID'.
- *
+ * Generate a random accountID base on searchValue.
+ * @param {String} searchValue
  * @returns {Number}
  */
-function generateAccountID() {
-    return Math.floor(Math.random() * 2 ** 21) * 2 ** 32 + Math.floor(Math.random() * 2 ** 32);
+function generateAccountID(searchValue) {
+    return hashText(searchValue, 2 ** 32);
 }
 
 export {

src/libs/actions/Task.js

@@ -498,7 +498,7 @@ function setAssigneeValue(assignee, assigneeAccountID, shareDestination, isCurre
 
     // Generate optimistic accountID if this is a brand new user account that hasn't been created yet
     if (!newAssigneeAccountID) {
-        newAssigneeAccountID = UserUtils.generateAccountID();
+        newAssigneeAccountID = UserUtils.generateAccountID(assignee);
     }
     if (!isCurrentUser) {
         let newChat = {};