Skip to content

Commit e6befa3

Browse files
committed
attempt to preserve the accessibility status
1 parent 2833a20 commit e6befa3

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

.github/actions/createOrUpdateStagingDeploy/createOrUpdateStagingDeploy.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,9 @@ const run = function () {
101101
// Since this is the second argument to _.union,
102102
// it will appear later in the array than any duplicate.
103103
// Since it is later in the array, it will be truncated by _.unique,
104-
// and the original value of isVerified will be preserved.
104+
// and the original value of isVerified and isAccessible will be preserved.
105105
isVerified: false,
106+
isAccessible: false,
106107
}))),
107108
false,
108109
item => item.number,
@@ -123,7 +124,8 @@ const run = function () {
123124
return GithubUtils.generateStagingDeployCashBody(
124125
tag,
125126
_.pluck(PRList, 'url'),
126-
_.pluck(_.where(PRList, {isVerified: true}), 'url'),
127+
_.pluck(_.where(PRList, {isVerified: true,}), 'url'),
128+
_.pluck(_.where(PRList, {isAccessible: true,}), 'url'),
127129
_.pluck(deployBlockers, 'url'),
128130
_.pluck(_.where(deployBlockers, {isResolved: true}), 'url'),
129131
);

.github/libs/GithubUtils.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@ class GithubUtils {
189189
* @param {String} tag
190190
* @param {Array} PRList - The list of PR URLs which are included in this StagingDeployCash
191191
* @param {Array} [verifiedPRList] - The list of PR URLs which have passed QA.
192+
* @param {Array} [accessabilityPRList] - The list of PR URLs which have passed the accessability check.
192193
* @param {Array} [deployBlockers] - The list of DeployBlocker URLs.
193194
* @param {Array} [resolvedDeployBlockers] - The list of DeployBlockers URLs which have been resolved.
194195
* @returns {Promise}
@@ -197,6 +198,7 @@ class GithubUtils {
197198
tag,
198199
PRList,
199200
verifiedPRList = [],
201+
accessabilityPRList = [],
200202
deployBlockers = [],
201203
resolvedDeployBlockers = [],
202204
) {
@@ -227,7 +229,7 @@ class GithubUtils {
227229
_.each(sortedPRList, (URL) => {
228230
issueBody += `\r\n\r\n- ${URL}`;
229231
issueBody += _.contains(verifiedPRList, URL) ? '\r\n - [x] QA' : '\r\n - [ ] QA';
230-
issueBody += '\r\n - [ ] Accessibility';
232+
issueBody += _.contains(accessabilityPRList, URL) ? '\r\n - [x] Accessibility' : '\r\n - [ ] Accessibility';
231233
});
232234
}
233235

@@ -237,7 +239,7 @@ class GithubUtils {
237239
_.each(sortedDeployBlockers, (URL) => {
238240
issueBody += `\r\n\r\n- ${URL}`;
239241
issueBody += _.contains(resolvedDeployBlockers, URL) ? '\r\n - [x] QA' : '\r\n - [ ] QA';
240-
issueBody += '\r\n - [ ] Accessibility';
242+
issueBody += _.contains(accessabilityPRList, URL) ? '\r\n - [x] Accessibility' : '\r\n - [ ] Accessibility';
241243
});
242244
}
243245

0 commit comments

Comments
 (0)