Merge pull request #9961 from Expensify/marcaaron-fixPusherReauthenticationIssue

Return `data` from `Reauthentication` middleware when `shouldRetry: false`

Author: chiragsalian

src/components/TestToolMenu.js

@@ -9,7 +9,6 @@ import * as Network from '../libs/actions/Network';
 import * as Session from '../libs/actions/Session';
 import ONYXKEYS from '../ONYXKEYS';
 import Button from './Button';
-import * as NetworkStore from '../libs/Network/NetworkStore';
 import TestToolRow from './TestToolRow';
 import networkPropTypes from './networkPropTypes';
 import compose from '../libs/compose';
@@ -60,7 +59,7 @@ const TestToolMenu = props => (
             <Button
                 small
                 text="Invalidate"
-                onPress={() => NetworkStore.setAuthToken('pizza')}
+                onPress={() => Session.invalidateAuthToken()}
             />
         </TestToolRow>
 

src/libs/Middleware/Reauthentication.js

@@ -42,7 +42,7 @@ function Reauthentication(response, request, isFromSequentialQueue) {
                     if (request.resolve) {
                         request.resolve(data);
                     }
-                    return;
+                    return data;
                 }
 
                 // We are already authenticating

src/libs/actions/Session/index.js

@@ -343,6 +343,11 @@ function invalidateCredentials() {
     Onyx.merge(ONYXKEYS.CREDENTIALS, {autoGeneratedLogin: '', autoGeneratedPassword: ''});
 }
 
+function invalidateAuthToken() {
+    NetworkStore.setAuthToken('pizza');
+    Onyx.merge(ONYXKEYS.SESSION, {authToken: 'pizza'});
+}
+
 /**
  * Clear the credentials and partial sign in session so the user can taken back to first Login step
  */
@@ -520,4 +525,5 @@ export {
     setShouldShowComposeInput,
     changePasswordAndSignIn,
     invalidateCredentials,
+    invalidateAuthToken,
 };

src/pages/settings/PreferencesPage.js

@@ -101,7 +101,7 @@ const PreferencesPage = (props) => {
                     </View>
 
                     {/* If we are in the staging environment then we enable additional test features */}
-                    {props.environment === CONST.ENVIRONMENT.STAGING && <TestToolMenu />}
+                    {_.contains([CONST.ENVIRONMENT.STAGING, CONST.ENVIRONMENT.DEV], props.environment) && <TestToolMenu />}
                 </View>
             </ScrollView>
         </ScreenWrapper>