Skip to content

Commit c08f4b6

Browse files
committed
Merge branch 'main' into ts/ShareCodePage
2 parents 88686d4 + 6c2882a commit c08f4b6

File tree

105 files changed

+1594
-1246
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

105 files changed

+1594
-1246
lines changed

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ android {
9898
minSdkVersion rootProject.ext.minSdkVersion
9999
targetSdkVersion rootProject.ext.targetSdkVersion
100100
multiDexEnabled rootProject.ext.multiDexEnabled
101-
versionCode 1001043505
102-
versionName "1.4.35-5"
101+
versionCode 1001043600
102+
versionName "1.4.36-0"
103103
}
104104

105105
flavorDimensions "default"

contributingGuides/APPLE_GOOGLE_SIGNIN.md

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,33 @@ if (CONFIG.ENVIRONMENT === CONST.ENVIRONMENT.DEV) {
259259
}
260260
```
261261

262-
#### Port requirements
262+
#### Host/Port requirements
263263

264264
Google allows the web app to be hosted at localhost, but according to the
265265
current Google console configuration for the Expensify client ID, it must be
266266
hosted on port 8082.
267267

268+
Also note that you'll need to update the webpack.dev.js config to change `host` from `dev.new.expensify.com` to `localhost` and server type from `https` to `http`. The reason for this is that Google Sign In allows localhost, but `dev.new.expensify.com` is not a registered Google Sign In domain.
269+
270+
```diff
271+
diff --git a/config/webpack/webpack.dev.js b/config/webpack/webpack.dev.js
272+
index e28383eff5..b14f6f34aa 100644
273+
--- a/config/webpack/webpack.dev.js
274+
+++ b/config/webpack/webpack.dev.js
275+
@@ -44,9 +44,9 @@ module.exports = (env = {}) =>
276+
...proxySettings,
277+
historyApiFallback: true,
278+
port,
279+
- host: 'dev.new.expensify.com',
280+
+ host: 'localhost',
281+
server: {
282+
- type: 'https',
283+
+ type: 'http',
284+
options: {
285+
key: path.join(__dirname, 'key.pem'),
286+
cert: path.join(__dirname, 'certificate.pem'),
287+
```
288+
268289
### Desktop
269290

270291
#### Set Environment to something other than "Development"

docs/_includes/end-option.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
</div>

docs/_includes/end-selector.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
</div>

docs/_includes/option.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
<div class="option-{{ include.value }}" markdown="1">

docs/_includes/selector.html

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{% assign values = include.values | split: "," %}
2+
3+
<div class="selector-container">
4+
5+
<select class="selector" onchange="selectOption(this)">
6+
{% for value in values %}
7+
<option value="option-{{ value | strip | downcase }}">{{ value | strip | capitalize }}</option>
8+
{% endfor %}
9+
</select>

docs/_layouts/default.html

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
<script src="https://kit.fontawesome.com/263e5e8608.js" crossorigin="anonymous"></script>
1313
<script defer src="https://cdnjs.cloudflare.com/ajax/libs/tocbot/4.12.0/tocbot.js"></script>
1414
<script defer src="/assets/js/main.js"></script>
15+
<script defer src="/assets/js/platform-tabs.js"></script>
16+
<script defer src="/assets/js/selector.js"></script>
1517
<script async src="https://cse.google.com/cse.js?cx=41f40d6e5c14246ff"></script>
1618
<!-- Google Tag Manager -->
1719
<script>(function (w, d, s, l, i) { w[l] = w[l] || []; w[l].push({ 'gtm.start': new Date().getTime(), event: 'gtm.js' }); var f = d.getElementsByTagName(s)[0], j = d.createElement(s), dl = l != 'dataLayer' ? '&l=' + l : ''; j.async = true; j.src = 'https://www.googletagmanager.com/gtm.js?id=' + i + dl; f.parentNode.insertBefore(j, f); })(window, document, 'script', 'dataLayer', 'GTM-TQBQW7CR');</script>
@@ -64,10 +66,13 @@
6466
<div id="article-content">
6567
<!-- Article title (only shown in article pages) -->
6668
{% if page.url contains "/articles/" %}
67-
<h1 class="title">
68-
{{ page.name | remove: '.md' | split: "-" | join: " " }}
69-
</h1>
70-
69+
<div class="title-platform-tabs">
70+
<h1 class="title">
71+
{{ page.name | remove: '.md' | split: "-" | join: " " }}
72+
</h1>
73+
<div id="platform-tabs">
74+
</div>
75+
</div>
7176
<div class="article-toc-content article">
7277
{{ content }}
7378
</div>

docs/_sass/_main.scss

Lines changed: 89 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,10 +350,14 @@ button {
350350
h1 {
351351
&.title {
352352
font-size: 2.25em;
353+
flex: 1;
353354
}
354355
}
355356

356357
.article {
358+
.hidden {
359+
display: none;
360+
}
357361
img {
358362
display: block;
359363
margin: 20px auto;
@@ -459,6 +463,49 @@ button {
459463
}
460464
}
461465

466+
.selector-container {
467+
background-color: $color-highlightBG;
468+
display: flex;
469+
flex-direction: row-reverse;
470+
gap: 20px;
471+
border-radius: 12px;
472+
padding: 20px;
473+
margin-bottom: 20px;
474+
justify-content: space-between;
475+
* > ol, ul {
476+
padding: 0;
477+
}
478+
479+
@include maxBreakpoint($breakpoint-tablet) {
480+
flex-direction: column;
481+
}
482+
}
483+
484+
select {
485+
height: 28px;
486+
border-radius: 20px;
487+
padding: 0px 26px 0px 12px;
488+
color: $color-text;
489+
font-size: 11px;
490+
font-weight: 700;
491+
text-align: center;
492+
cursor: pointer;
493+
494+
@include maxBreakpoint($breakpoint-tablet) {
495+
width: 100px;
496+
}
497+
498+
}
499+
500+
select {
501+
background: url("/assets/images/down.svg") no-repeat right $color-button-background;
502+
background-size: 12px;
503+
background-position-x: 85%;
504+
appearance: none !important;
505+
-moz-appearance: none !important;
506+
-webkit-appearance: none !important;
507+
}
508+
462509
.info {
463510
padding: 12px;
464511
border-radius: 8px;
@@ -862,3 +909,45 @@ button {
862909
}
863910
}
864911
}
912+
913+
.title-platform-tabs {
914+
display: flex;
915+
justify-content: space-between;
916+
padding-bottom: 12px;
917+
h1 {
918+
padding: 0;
919+
}
920+
921+
@include maxBreakpoint($breakpoint-tablet) {
922+
flex-direction: column;
923+
gap: 20px;
924+
}
925+
}
926+
927+
#platform-tabs {
928+
display: flex;
929+
flex-wrap: wrap;
930+
align-items: center;
931+
text-align: center;
932+
font-weight: 700;
933+
font-size: 13px;
934+
gap: 4px;
935+
}
936+
937+
#platform-tabs > * {
938+
cursor: pointer;
939+
border-radius: 20px;
940+
padding: 10px 20px;
941+
box-sizing: border-box;
942+
height: 36px;
943+
line-height: 16px;
944+
}
945+
946+
#platform-tabs > .active {
947+
color: $color-text;
948+
background-color: $color-button-background;
949+
}
950+
951+
.hidden {
952+
display: none;
953+
}

0 commit comments

Comments
 (0)