You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
about: A template to follow when creating a new issue for accessibility failures
4
4
---
5
5
6
-
If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/CONTRIBUTING.md) for onboarding and email [email protected] to request to join our Slack channel!
6
+
If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/docs/CONTRIBUTING.md) for onboarding and email [email protected] to request to join our Slack channel!
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/Performance.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -5,7 +5,7 @@ title: "[Performance] "
5
5
labels: Engineering, Daily
6
6
---
7
7
8
-
If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/CONTRIBUTING.md) for onboarding and email [email protected] to request to join our Slack channel!
8
+
If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/docs/CONTRIBUTING.md) for onboarding and email [email protected] to request to join our Slack channel!
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/Standard.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -4,7 +4,7 @@ about: A standard template to follow when creating a new issue in this repositor
4
4
labels: AutoAssignerTriage, Daily
5
5
---
6
6
7
-
If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/CONTRIBUTING.md) for onboarding and email [email protected] to request to join our Slack channel!
7
+
If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/docs/CONTRIBUTING.md) for onboarding and email [email protected] to request to join our Slack channel!
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+28-22Lines changed: 28 additions & 22 deletions
Original file line number
Diff line number
Diff line change
@@ -42,25 +42,25 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all
42
42
-[ ] I added steps for Staging and/or Production testing in the `QA steps` section
43
43
-[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
44
44
-[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
45
-
-[ ] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
45
+
-[ ] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/docs/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
46
46
-[ ] I ran the tests on **all platforms** & verified they passed on:
47
47
-[ ] iOS / native
48
48
-[ ] Android / native
49
49
-[ ] iOS / Safari
50
50
-[ ] Android / Chrome
51
51
-[ ] MacOS / Chrome
52
52
-[ ] MacOS / Desktop
53
-
-[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
54
-
-[ ] I followed proper code patterns (see [Reviewing the code](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md#reviewing-the-code))
53
+
-[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
54
+
-[ ] I followed proper code patterns (see [Reviewing the code](https://github.com/Expensify/App/blob/main/docs/PR_REVIEW_GUIDELINES.md#reviewing-the-code))
55
55
-[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. `toggleReport` and not `onIconClick`)
56
56
-[ ] I verified that comments were added to code that is not self explanatory
57
-
-[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
57
+
-[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
58
58
-[ ] I verified any copy / text shown in the product was added in all `src/languages/*` files
59
59
-[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
60
-
-[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
61
-
-[ ] I verified the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/STYLE.md#jsdocs)) were followed
60
+
-[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
61
+
-[ ] I verified the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/docs/STYLE.md#jsdocs)) were followed
62
62
-[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
63
-
-[ ] I followed the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md)
63
+
-[ ] I followed the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/docs/PR_REVIEW_GUIDELINES.md)
64
64
-[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` are working as expected)
65
65
-[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
66
66
-[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
@@ -74,42 +74,47 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all
74
74
-[ ] For Class Components, any internal methods passed to components event handlers are bound to `this` properly so there are no scoping issues (i.e. for `onClick={this.submit}` the method `this.submit` should be bound to `this` in the constructor)
75
75
-[ ] Any internal methods bound to `this` are necessary to be bound (i.e. avoid `this.submit = this.submit.bind(this);` if `this.submit` is never passed to a component event handler like `onClick`)
76
76
-[ ] All JSX used for rendering exists in the render method
77
-
-[ ] The component has the minimum amount of code necessary for its purpose and it is
77
+
-[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
78
78
-[ ] If a new CSS style is added I verified that:
79
-
-[ ] A similar style doesn’t already exist
80
-
-[ ] The style can’t be created with an existing [StyleUtils](https://github.com/Expensify/App/blob/main/src/styles/StyleUtils.js) function (i.e. `StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG`)
79
+
-[ ] A similar style doesn't already exist
80
+
-[ ] The style can't be created with an existing [StyleUtils](https://github.com/Expensify/App/blob/main/src/styles/StyleUtils.js) function (i.e. `StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG`)
81
81
-[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like `Avatar` is modified, I verified that `Avatar` is working as expected in all cases)
82
82
-[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
83
-
83
+
-[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
84
84
85
85
<details>
86
-
<summary><h4>PR Reviewer Checklist</h4></summary>
86
+
<summary><h4>PR Reviewer Checklist</h4>
87
+
88
+
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
89
+
</summary>
87
90
91
+
-[ ] I have verified the author checklist is complete (all boxes are checked off).
88
92
-[ ] I verified the correct issue is linked in the `### Fixed Issues` section above
89
93
-[ ] I verified testing steps are clear and they cover the changes made in this PR
90
94
-[ ] I verified the steps for local testing are in the `Tests` section
91
95
-[ ] I verified the steps for Staging and/or Production testing are in the `QA steps` section
92
96
-[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
93
97
-[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
94
-
-[ ] I checked that screenshots or videos are included for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
98
+
-[ ] I checked that screenshots or videos are included for tests on [all platforms](https://github.com/Expensify/App/blob/main/docs/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
95
99
-[ ] I verified tests pass on **all platforms** & I tested again on:
96
100
-[ ] iOS / native
97
101
-[ ] Android / native
98
102
-[ ] iOS / Safari
99
103
-[ ] Android / Chrome
100
104
-[ ] MacOS / Chrome
101
105
-[ ] MacOS / Desktop
102
-
-[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
103
-
-[ ] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md#reviewing-the-code))
106
+
-[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
107
+
-[ ] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/docs/PR_REVIEW_GUIDELINES.md#reviewing-the-code))
104
108
-[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. `toggleReport` and not `onIconClick`).
105
109
-[ ] I verified that comments were added to code that is not self explanatory
106
-
-[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
110
+
-[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
107
111
-[ ] I verified any copy / text shown in the product was added in all `src/languages/*` files
108
112
-[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
109
-
-[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
110
-
-[ ] I verified the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/STYLE.md#jsdocs)) were followed
113
+
-[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
114
+
-[ ] I verified the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/docs/STYLE.md#jsdocs)) were followed
111
115
-[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
112
-
-[ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md)
116
+
-[ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/docs/PR_REVIEW_GUIDELINES.md)
117
+
-[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` have been tested & I retested again)
113
118
-[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
114
119
-[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
115
120
-[ ] If a new component is created I verified that:
@@ -122,12 +127,13 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all
122
127
-[ ] For Class Components, any internal methods passed to components event handlers are bound to `this` properly so there are no scoping issues (i.e. for `onClick={this.submit}` the method `this.submit` should be bound to `this` in the constructor)
123
128
-[ ] Any internal methods bound to `this` are necessary to be bound (i.e. avoid `this.submit = this.submit.bind(this);` if `this.submit` is never passed to a component event handler like `onClick`)
124
129
-[ ] All JSX used for rendering exists in the render method
125
-
-[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
130
+
-[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
126
131
-[ ] If a new CSS style is added I verified that:
127
-
-[ ] A similar style doesn’t already exist
128
-
-[ ] The style can’t be created with an existing [StyleUtils](https://github.com/Expensify/App/blob/main/src/styles/StyleUtils.js) function (i.e. `StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG`)
132
+
-[ ] A similar style doesn't already exist
133
+
-[ ] The style can't be created with an existing [StyleUtils](https://github.com/Expensify/App/blob/main/src/styles/StyleUtils.js) function (i.e. `StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG`)
129
134
-[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like `Avatar` is modified, I verified that `Avatar` is working as expected in all cases)
130
135
-[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
136
+
-[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
0 commit comments