optimize the code

Author: bernhardoj

src/pages/home/report/ReportActionItem.js

@@ -138,13 +138,17 @@ function ReportActionItem(props) {
     const originalReportID = ReportUtils.getOriginalReportID(props.report.reportID, props.action);
     const originalReport = props.report.reportID === originalReportID ? props.report : ReportUtils.getReport(originalReportID);
 
-    useEffect(() => {
-        const isAttachment = ReportUtils.isReportMessageAttachment(_.last(props.action.message));
-        if (!isAttachment) {
-            return;
-        }
-        updateHiddenAttachments(props.action.reportActionID, isHidden);
-    }, [props.action.reportActionID, props.action.message, isHidden, updateHiddenAttachments]);
+    const updateHiddenState = useCallback(
+        (isHiddenValue) => {
+            setIsHidden(isHiddenValue);
+            const isAttachment = ReportUtils.isReportMessageAttachment(_.last(props.action.message));
+            if (!isAttachment) {
+                return;
+            }
+            updateHiddenAttachments(props.action.reportActionID, isHiddenValue);
+        },
+        [props.action.reportActionID, props.action.message, updateHiddenAttachments],
+    );
 
     useEffect(
         () => () => {
@@ -371,7 +375,7 @@ function ReportActionItem(props) {
                                 <Button
                                     small
                                     style={[styles.mt2, styles.alignSelfStart]}
-                                    onPress={() => setIsHidden(!isHidden)}
+                                    onPress={() => updateHiddenState(!isHidden)}
                                 >
                                     <Text
                                         style={styles.buttonSmallText}