Skip to content

Commit a5f2739

Browse files
authored
Merge pull request #5726 from parasharrajat/newWorkspaceInvite
Refactor Workspace Invite Member page
2 parents 64cb863 + add3414 commit a5f2739

File tree

9 files changed

+246
-170
lines changed

9 files changed

+246
-170
lines changed

src/components/FormAlertWithSubmitButton.js

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ const propTypes = {
1616
/** Whether to show the alert text */
1717
isAlertVisible: PropTypes.bool.isRequired,
1818

19+
/** Whether the button is disabled */
20+
isDisabled: PropTypes.bool,
21+
1922
/** Submit function */
2023
onSubmit: PropTypes.func.isRequired,
2124

@@ -31,22 +34,29 @@ const propTypes = {
3134
/** Whether message is in html format */
3235
isMessageHtml: PropTypes.bool,
3336

37+
/** Styles for container element */
38+
containerStyles: PropTypes.arrayOf(PropTypes.object),
39+
3440
...withLocalizePropTypes,
3541
};
3642

3743
const defaultProps = {
3844
message: '',
45+
isDisabled: false,
3946
isMessageHtml: false,
47+
containerStyles: [],
4048
};
4149

4250
const FormAlertWithSubmitButton = ({
4351
isAlertVisible,
52+
isDisabled,
4453
onSubmit,
4554
buttonText,
4655
translate,
4756
onFixTheErrorsLinkPressed,
4857
message,
4958
isMessageHtml,
59+
containerStyles,
5060
}) => {
5161
/**
5262
* @returns {React.Component}
@@ -91,7 +101,7 @@ const FormAlertWithSubmitButton = ({
91101
}
92102

93103
return (
94-
<View style={[styles.mh5, styles.mb5, styles.flex1, styles.justifyContentEnd]}>
104+
<View style={[styles.mh5, styles.mb5, styles.flex1, styles.justifyContentEnd, ...containerStyles]}>
95105
{isAlertVisible && (
96106
<View style={[styles.flexRow, styles.alignItemsCenter, styles.mb3]}>
97107
<Icon src={Exclamation} fill={colors.red} />
@@ -100,9 +110,10 @@ const FormAlertWithSubmitButton = ({
100110
)}
101111
<Button
102112
success
113+
pressOnEnter
103114
text={buttonText}
104115
onPress={onSubmit}
105-
pressOnEnter
116+
isDisabled={isDisabled}
106117
/>
107118
</View>
108119
);

src/languages/en.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -702,14 +702,9 @@ export default {
702702
},
703703
invite: {
704704
invitePeople: 'Invite new members',
705-
invitePeoplePrompt: 'Invite new members to your workspace.',
706705
personalMessagePrompt: 'Add a personal message (optional)',
707-
enterEmailOrPhone: 'Emails or phone numbers',
708-
EmailOrPhonePlaceholder: 'Enter comma-separated list of emails or phone numbers',
709-
pleaseEnterValidLogin: 'Please ensure the email or phone number is valid (e.g. +15005550006).',
710-
pleaseEnterUniqueLogin: 'That user is already a member of this workspace.',
706+
pleaseSelectUser: 'Please select a user from contacts.',
711707
genericFailureMessage: 'An error occurred inviting the user to the workspace, please try again.',
712-
systemUserError: ({email}) => `Sorry, you cannot invite ${email} to a workspace.`,
713708
welcomeNote: ({workspaceName}) => `You have been invited to ${workspaceName}! Download the Expensify mobile app to start tracking your expenses.`,
714709
},
715710
editor: {

src/languages/es.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -704,14 +704,9 @@ export default {
704704
},
705705
invite: {
706706
invitePeople: 'Invitar nuevos miembros',
707-
invitePeoplePrompt: 'Invita nuevos miembros a tu espacio de trabajo.',
708707
personalMessagePrompt: 'Agregar un mensaje personal (Opcional)',
709-
enterEmailOrPhone: 'Correos electrónicos o números de teléfono',
710-
EmailOrPhonePlaceholder: 'Introduce una lista de correos electrónicos o números de teléfono separado por comas',
711-
pleaseEnterValidLogin: 'Asegúrese de que el correo electrónico o el número de teléfono sean válidos (e.g. +15005550006).',
712-
pleaseEnterUniqueLogin: 'Ese usuario ya es miembro de este espacio de trabajo.',
708+
pleaseSelectUser: 'Asegúrese de que el correo electrónico o el número de teléfono sean válidos (e.g. +15005550006).',
713709
genericFailureMessage: 'Se produjo un error al invitar al usuario al espacio de trabajo. Vuelva a intentarlo..',
714-
systemUserError: ({email}) => `Lo sentimos, no puedes invitar a ${email} a un espacio de trabajo.`,
715710
welcomeNote: ({workspaceName}) => `¡Has sido invitado a ${workspaceName}! Descargue la aplicación móvil Expensify para comenzar a rastrear sus gastos.`,
716711
},
717712
editor: {

src/libs/actions/Policy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ function invite(logins, welcomeNote, policyID) {
248248
policy.alertMessage = '';
249249

250250
// Optimistically add the user to the policy
251-
Onyx.set(key, policy);
251+
Onyx.merge(key, policy);
252252

253253
// Make the API call to merge the login into the policy
254254
API.Policy_Employees_Merge({

src/libs/userUtils.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)