Skip to content

Commit 8b9cc72

Browse files
committed
Apply review suggestions
1 parent b3e80b3 commit 8b9cc72

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

src/components/MoneyReportHeader.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ import {
3939
hasUpdatedTotal,
4040
isAllowedToApproveExpenseReport,
4141
isExported as isExportedUtils,
42-
isInvoiceReport,
42+
isInvoiceReport as isInvoiceReportUtil,
4343
isProcessingReport,
4444
isReportOwner,
45-
isTrackExpenseReport,
45+
isTrackExpenseReport as isTrackExpenseReportUtil,
4646
navigateToDetailsPage,
4747
reportTransactionsSelector,
4848
} from '@libs/ReportUtils';
@@ -208,19 +208,19 @@ function MoneyReportHeader({policy, report: moneyRequestReport, transactionThrea
208208
[moneyRequestReport, chatReport, policy, transaction],
209209
);
210210

211-
const isInvoice = isInvoiceReport(moneyRequestReport);
212-
const isTrackExpense = isTrackExpenseReport(moneyRequestReport);
211+
const isInvoiceReport = isInvoiceReportUtil(moneyRequestReport);
212+
const isTrackExpenseReport = isTrackExpenseReportUtil(moneyRequestReport);
213213

214214
const iouType = useMemo(() => {
215-
if (isTrackExpense) {
215+
if (isTrackExpenseReport) {
216216
return CONST.IOU.TYPE.TRACK;
217217
}
218-
if (isInvoice) {
218+
if (isInvoiceReport) {
219219
return CONST.IOU.TYPE.INVOICE;
220220
}
221221

222222
return CONST.IOU.TYPE.SUBMIT;
223-
}, [isTrackExpense, isInvoice]);
223+
}, [isTrackExpenseReport, isInvoiceReport]);
224224

225225
const [isDownloadErrorModalVisible, setIsDownloadErrorModalVisible] = useState(false);
226226

@@ -290,15 +290,15 @@ function MoneyReportHeader({policy, report: moneyRequestReport, transactionThrea
290290
setIsNoDelegateAccessMenuVisible(true);
291291
} else if (isAnyTransactionOnHold) {
292292
setIsHoldMenuVisible(true);
293-
} else if (isInvoice) {
293+
} else if (isInvoiceReport) {
294294
startAnimation();
295295
payInvoice(type, chatReport, moneyRequestReport, payAsBusiness, methodID, paymentMethod);
296296
} else {
297297
startAnimation();
298298
payMoneyRequest(type, chatReport, moneyRequestReport, true);
299299
}
300300
},
301-
[chatReport, isAnyTransactionOnHold, isDelegateAccessRestricted, isInvoice, moneyRequestReport, startAnimation],
301+
[chatReport, isAnyTransactionOnHold, isDelegateAccessRestricted, isInvoiceReport, moneyRequestReport, startAnimation],
302302
);
303303

304304
const confirmApproval = () => {

src/hooks/useSelectedTransactionsActions.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,7 @@ function useSelectedTransactionsActions({
157157
},
158158
});
159159

160-
const canAllExpensesBeMoved = selectedTransactions.every((transaction) => {
161-
// typescript is failing without this check
160+
const canSelectedExpensesBeMoved = selectedTransactions.every((transaction) => {
162161
if (!transaction) {
163162
return false;
164163
}
@@ -169,7 +168,7 @@ function useSelectedTransactionsActions({
169168
});
170169

171170
const canUserPerformWriteAction = canUserPerformWriteActionReportUtils(report);
172-
if (canAllExpensesBeMoved && canUserPerformWriteAction) {
171+
if (canSelectedExpensesBeMoved && canUserPerformWriteAction) {
173172
options.push({
174173
text: translate('iou.moveExpenses', {count: selectedTransactionsID.length}),
175174
icon: Expensicons.DocumentMerge,

0 commit comments

Comments
 (0)