Skip to content

Commit 862d4aa

Browse files
authored
Merge pull request #46431 from shubham1206agra/fix-offline-indicator-report-fields
2 parents 459759d + 1b30bc1 commit 862d4aa

File tree

1 file changed

+45
-43
lines changed

1 file changed

+45
-43
lines changed

src/pages/workspace/reportFields/ReportFieldsSettingsPage.tsx

Lines changed: 45 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -69,49 +69,6 @@ function ReportFieldsSettingsPage({
6969
title={reportField.name}
7070
shouldSetModalVisibility={false}
7171
/>
72-
<MenuItemWithTopDescription
73-
style={[styles.moneyRequestMenuItem]}
74-
titleStyle={styles.flex1}
75-
title={reportField.name}
76-
description={translate('common.name')}
77-
interactive={false}
78-
/>
79-
<MenuItemWithTopDescription
80-
style={[styles.moneyRequestMenuItem]}
81-
titleStyle={styles.flex1}
82-
title={Str.recapitalize(translate(WorkspaceReportFieldUtils.getReportFieldTypeTranslationKey(reportField.type)))}
83-
description={translate('common.type')}
84-
interactive={false}
85-
/>
86-
{!isListFieldEmpty && (
87-
<MenuItemWithTopDescription
88-
style={[styles.moneyRequestMenuItem]}
89-
titleStyle={styles.flex1}
90-
title={WorkspaceReportFieldUtils.getReportFieldInitialValue(reportField)}
91-
description={translate('common.initialValue')}
92-
shouldShowRightIcon={!isDateFieldType && !hasAccountingConnections}
93-
interactive={!isDateFieldType && !hasAccountingConnections}
94-
onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_REPORT_FIELDS_INITIAL_VALUE.getRoute(policyID, reportFieldID))}
95-
/>
96-
)}
97-
{isListFieldType && (
98-
<MenuItemWithTopDescription
99-
style={[styles.moneyRequestMenuItem]}
100-
titleStyle={styles.flex1}
101-
description={translate('workspace.reportFields.listValues')}
102-
shouldShowRightIcon
103-
onPress={() => Navigation.navigate(ROUTES.WORKSPACE_REPORT_FIELDS_LIST_VALUES.getRoute(policyID, reportFieldID))}
104-
/>
105-
)}
106-
{!hasAccountingConnections && (
107-
<View style={styles.flexGrow1}>
108-
<MenuItem
109-
icon={Expensicons.Trashcan}
110-
title={translate('common.delete')}
111-
onPress={() => setIsDeleteModalVisible(true)}
112-
/>
113-
</View>
114-
)}
11572
<ConfirmModal
11673
title={translate('workspace.reportFields.delete')}
11774
isVisible={isDeleteModalVisible && !hasAccountingConnections}
@@ -123,6 +80,51 @@ function ReportFieldsSettingsPage({
12380
cancelText={translate('common.cancel')}
12481
danger
12582
/>
83+
<View style={styles.flexGrow1}>
84+
<MenuItemWithTopDescription
85+
style={[styles.moneyRequestMenuItem]}
86+
titleStyle={styles.flex1}
87+
title={reportField.name}
88+
description={translate('common.name')}
89+
interactive={false}
90+
/>
91+
<MenuItemWithTopDescription
92+
style={[styles.moneyRequestMenuItem]}
93+
titleStyle={styles.flex1}
94+
title={Str.recapitalize(translate(WorkspaceReportFieldUtils.getReportFieldTypeTranslationKey(reportField.type)))}
95+
description={translate('common.type')}
96+
interactive={false}
97+
/>
98+
{!isListFieldEmpty && (
99+
<MenuItemWithTopDescription
100+
style={[styles.moneyRequestMenuItem]}
101+
titleStyle={styles.flex1}
102+
title={WorkspaceReportFieldUtils.getReportFieldInitialValue(reportField)}
103+
description={translate('common.initialValue')}
104+
shouldShowRightIcon={!isDateFieldType && !hasAccountingConnections}
105+
interactive={!isDateFieldType && !hasAccountingConnections}
106+
onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_REPORT_FIELDS_INITIAL_VALUE.getRoute(policyID, reportFieldID))}
107+
/>
108+
)}
109+
{isListFieldType && (
110+
<MenuItemWithTopDescription
111+
style={[styles.moneyRequestMenuItem]}
112+
titleStyle={styles.flex1}
113+
description={translate('workspace.reportFields.listValues')}
114+
shouldShowRightIcon
115+
onPress={() => Navigation.navigate(ROUTES.WORKSPACE_REPORT_FIELDS_LIST_VALUES.getRoute(policyID, reportFieldID))}
116+
/>
117+
)}
118+
{!hasAccountingConnections && (
119+
<View style={styles.flexGrow1}>
120+
<MenuItem
121+
icon={Expensicons.Trashcan}
122+
title={translate('common.delete')}
123+
onPress={() => setIsDeleteModalVisible(true)}
124+
/>
125+
</View>
126+
)}
127+
</View>
126128
</ScreenWrapper>
127129
</AccessOrNotFoundWrapper>
128130
);

0 commit comments

Comments
 (0)