Skip to content

Commit 65d675b

Browse files
committed
Revert "Merge pull request #56602 from Amoralchik/clickable-emoji-for-exoense-task"
This reverts commit a1fae23, reversing changes made to d47c197.
1 parent fccf6ee commit 65d675b

File tree

18 files changed

+138
-290
lines changed

18 files changed

+138
-290
lines changed

assets/images/customEmoji/global-create.svg

Lines changed: 0 additions & 14 deletions
This file was deleted.

src/CONST.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ const onboardingEmployerOrSubmitMessage: OnboardingMessage = {
156156
'\n' +
157157
'Here’s how to submit an expense:\n' +
158158
'\n' +
159-
'1. Press the <custom-emoji emoji="actionMenuIcon" pressablewithdefaultaction /> button.\n' +
159+
'1. Click the green *+* button.\n' +
160160
'2. Choose *Create expense*.\n' +
161161
'3. Enter an amount or scan a receipt.\n' +
162162
'4. Add your reimburser to the request.\n' +
@@ -179,7 +179,7 @@ const combinedTrackSubmitOnboardingEmployerOrSubmitMessage: OnboardingMessage =
179179
'\n' +
180180
'Here’s how to submit an expense:\n' +
181181
'\n' +
182-
'1. Press the <custom-emoji emoji="actionMenuIcon" pressablewithdefaultaction /> button.\n' +
182+
'1. Click the green *+* button.\n' +
183183
'2. Choose *Create expense*.\n' +
184184
'3. Enter an amount or scan a receipt.\n' +
185185
'4. Add your reimburser to the request.\n' +
@@ -203,7 +203,7 @@ const onboardingPersonalSpendMessage: OnboardingMessage = {
203203
'\n' +
204204
'Here’s how to track an expense:\n' +
205205
'\n' +
206-
'1. Press the <custom-emoji emoji="actionMenuIcon" pressablewithdefaultaction /> button.\n' +
206+
'1. Click the green *+* button.\n' +
207207
'2. Choose *Create expense*.\n' +
208208
'3. Enter an amount or scan a receipt.\n' +
209209
'4. Choose your *personal* space.\n' +
@@ -226,7 +226,7 @@ const combinedTrackSubmitOnboardingPersonalSpendMessage: OnboardingMessage = {
226226
'\n' +
227227
'Here’s how to track an expense:\n' +
228228
'\n' +
229-
'1. Press the <custom-emoji emoji="actionMenuIcon" pressablewithdefaultaction /> button.\n' +
229+
'1. Click the green *+* button.\n' +
230230
'2. Choose *Create expense*.\n' +
231231
'3. Enter an amount or scan a receipt.\n' +
232232
'4. Choose your *personal* space.\n' +
@@ -5337,7 +5337,7 @@ const CONST = {
53375337
'\n' +
53385338
'Here’s how to start a chat:\n' +
53395339
'\n' +
5340-
'1. Press the <custom-emoji emoji="actionMenuIcon" pressablewithdefaultaction /> button.\n' +
5340+
'1. Click the green *+* button.\n' +
53415341
'2. Choose *Start chat*.\n' +
53425342
'3. Enter emails or phone numbers.\n' +
53435343
'\n' +
@@ -5354,7 +5354,7 @@ const CONST = {
53545354
'\n' +
53555355
'Here’s how to request money:\n' +
53565356
'\n' +
5357-
'1. Press the <custom-emoji emoji="actionMenuIcon" pressablewithdefaultaction /> button.\n' +
5357+
'1. Click the green *+* button.\n' +
53585358
'2. Choose *Start chat*.\n' +
53595359
'3. Enter any email, SMS, or name of who you want to split with.\n' +
53605360
'4. From within the chat, click the *+* button on the message bar, and click *Split expense*.\n' +
@@ -5388,7 +5388,7 @@ const CONST = {
53885388
'\n' +
53895389
'Here’s how to submit an expense:\n' +
53905390
'\n' +
5391-
'1. Press the <custom-emoji emoji="actionMenuIcon" pressablewithdefaultaction /> button.\n' +
5391+
'1. Click the green *+* button.\n' +
53925392
'2. Choose *Create expense*.\n' +
53935393
'3. Enter an amount or scan a receipt.\n' +
53945394
'4. Add your reimburser to the request.\n' +

src/components/FABPopoverProvider.tsx

Lines changed: 0 additions & 133 deletions
This file was deleted.

src/components/HTMLEngineProvider/BaseHTMLEngineProvider.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ function BaseHTMLEngineProvider({textSelectable = false, children, enableExperim
8080
'mention-user': HTMLElementModel.fromCustomModel({tagName: 'mention-user', contentModel: HTMLContentModel.textual}),
8181
'mention-report': HTMLElementModel.fromCustomModel({tagName: 'mention-report', contentModel: HTMLContentModel.textual}),
8282
'mention-here': HTMLElementModel.fromCustomModel({tagName: 'mention-here', contentModel: HTMLContentModel.textual}),
83-
'custom-emoji': HTMLElementModel.fromCustomModel({tagName: 'custom-emoji', contentModel: HTMLContentModel.textual}),
8483
'next-step': HTMLElementModel.fromCustomModel({
8584
tagName: 'next-step',
8685
mixedUAStyles: {...styles.textLabelSupporting, ...styles.lh16},

src/components/HTMLEngineProvider/CustomEmojiWithDefaultPressableAction.tsx

Lines changed: 0 additions & 45 deletions
This file was deleted.

src/components/HTMLEngineProvider/HTMLRenderers/CustomEmojiRenderer.tsx

Lines changed: 0 additions & 42 deletions
This file was deleted.

src/components/HTMLEngineProvider/HTMLRenderers/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import type {CustomTagRendererRecord} from 'react-native-render-html';
22
import AnchorRenderer from './AnchorRenderer';
33
import CodeRenderer from './CodeRenderer';
4-
import CustomEmojiRenderer from './CustomEmojiRenderer';
54
import DeletedActionRenderer from './DeletedActionRenderer';
65
import EditedRenderer from './EditedRenderer';
76
import EmojiRenderer from './EmojiRenderer';
@@ -30,7 +29,6 @@ const HTMLEngineProviderComponentList: CustomTagRendererRecord = {
3029
'mention-user': MentionUserRenderer,
3130
'mention-report': MentionReportRenderer,
3231
'mention-here': MentionHereRenderer,
33-
'custom-emoji': CustomEmojiRenderer,
3432
emoji: EmojiRenderer,
3533
'next-step-email': NextStepEmailRenderer,
3634
'deleted-action': DeletedActionRenderer,

src/components/Navigation/BottomTabBar/index.tsx

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
1-
import React, {memo, useCallback, useContext, useEffect, useState} from 'react';
1+
import React, {memo, useCallback, useEffect, useState} from 'react';
22
import {View} from 'react-native';
33
import {useOnyx} from 'react-native-onyx';
44
import type {ValueOf} from 'type-fest';
5-
import {FABPopoverContext} from '@components/FABPopoverProvider';
6-
import FloatingActionButton from '@components/FloatingActionButton';
75
import Icon from '@components/Icon';
86
import * as Expensicons from '@components/Icon/Expensicons';
97
import DebugTabView from '@components/Navigation/DebugTabView';
@@ -31,6 +29,7 @@ import Navigation from '@navigation/Navigation';
3129
import navigationRef from '@navigation/navigationRef';
3230
import type {AuthScreensParamList, RootNavigatorParamList, State, WorkspaceSplitNavigatorParamList} from '@navigation/types';
3331
import BottomTabAvatar from '@pages/home/sidebar/BottomTabAvatar';
32+
import BottomTabBarFloatingActionButton from '@pages/home/sidebar/BottomTabBarFloatingActionButton';
3433
import variables from '@styles/variables';
3534
import CONST from '@src/CONST';
3635
import NAVIGATORS from '@src/NAVIGATORS';
@@ -73,7 +72,6 @@ function handleQueryWithPolicyID(query: SearchQueryString, activePolicyID?: stri
7372
}
7473

7574
function BottomTabBar({selectedTab, isTooltipAllowed = false}: BottomTabBarProps) {
76-
const {isCreateMenuActive, toggleCreateMenu, fabRef} = useContext(FABPopoverContext);
7775
const theme = useTheme();
7876
const styles = useThemeStyles();
7977
const {translate} = useLocalize();
@@ -285,14 +283,7 @@ function BottomTabBar({selectedTab, isTooltipAllowed = false}: BottomTabBarProps
285283
onPress={showSettingsPage}
286284
/>
287285
<View style={[styles.flex1, styles.bottomTabBarItem]}>
288-
<FloatingActionButton
289-
accessibilityLabel={translate('sidebarScreen.fabNewChatExplained')}
290-
role={CONST.ROLE.BUTTON}
291-
isActive={isCreateMenuActive}
292-
ref={fabRef}
293-
onPress={() => toggleCreateMenu(isCreateMenuActive)}
294-
isTooltipAllowed={isTooltipAllowed}
295-
/>
286+
<BottomTabBarFloatingActionButton isTooltipAllowed={isTooltipAllowed} />
296287
</View>
297288
</View>
298289
</>

src/libs/Navigation/NavigationRoot.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import {DarkTheme, DefaultTheme, findFocusedRoute, NavigationContainer} from '@r
33
import React, {useContext, useEffect, useMemo, useRef} from 'react';
44
import {NativeModules} from 'react-native';
55
import {useOnyx} from 'react-native-onyx';
6-
import FABPopoverProvider from '@components/FABPopoverProvider';
76
import {ScrollOffsetContext} from '@components/ScrollOffsetContextProvider';
87
import {usePlaybackContext} from '@components/VideoPlayerContexts/PlaybackContext';
98
import useCurrentReportID from '@hooks/useCurrentReportID';
@@ -224,9 +223,7 @@ function NavigationRoot({authenticated, lastVisitedPath, initialUrl, onReady, sh
224223
enabled: false,
225224
}}
226225
>
227-
<FABPopoverProvider>
228-
<AppNavigator authenticated={authenticated} />
229-
</FABPopoverProvider>
226+
<AppNavigator authenticated={authenticated} />
230227
</NavigationContainer>
231228
);
232229
}

0 commit comments

Comments
 (0)