Merge pull request #59031 from nkdengineer/fix/58765

srikarparsi · web-flow · commit 58b8887a88ba · 2025-03-26T03:19:08.000-04:00
App crash during signin
diff --git a/src/libs/Navigation/NavigationRoot.tsx b/src/libs/Navigation/NavigationRoot.tsx
@@ -174,7 +174,7 @@ function NavigationRoot({authenticated, lastVisitedPath, initialUrl, onReady}: N
         // Since the NAVIGATORS.REPORTS_SPLIT_NAVIGATOR url is "/" and it has to be used as an URL for SignInPage,
         // this navigator should be the only one in the navigation state after logout.
         const hasUserLoggedOut = !authenticated && !!previousAuthenticated;
-        if (!hasUserLoggedOut) {
+        if (!hasUserLoggedOut || !navigationRef.isReady()) {
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ function NavigationRoot({authenticated, lastVisitedPath, initialUrl, onReady}: N`
`174`	`174`	`// Since the NAVIGATORS.REPORTS_SPLIT_NAVIGATOR url is "/" and it has to be used as an URL for SignInPage,`
`175`	`175`	`// this navigator should be the only one in the navigation state after logout.`
`176`	`176`	`const hasUserLoggedOut = !authenticated && !!previousAuthenticated;`
`177`		`- if (!hasUserLoggedOut) {`
	`177`	`+ if (!hasUserLoggedOut \|\| !navigationRef.isReady()) {`
`178`	`178`	`return;`
`179`	`179`	`}`
`180`	`180`