Skip to content

Commit 524a7d1

Browse files
authored
Merge pull request #46474 from CleverWolf1220/issue-42316
Chat - Offline indicator and message isn't visible for video attachment and preview
2 parents 636515a + 41248b7 commit 524a7d1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/components/VideoPlayer/BaseVideoPlayer.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ function BaseVideoPlayer({
189189
if (!status.isLoaded) {
190190
preventPausingWhenExitingFullscreen(false);
191191
setIsPlaying(false);
192-
setIsLoading(false); // when video is ready to display duration is not NaN
192+
setIsLoading(true); // when video is ready to display duration is not NaN
193193
setIsBuffering(false);
194194
setDuration(videoDuration * 1000);
195195
setPosition(0);
@@ -442,7 +442,7 @@ function BaseVideoPlayer({
442442
)}
443443
</PressableWithoutFeedback>
444444
{((isLoading && !isOffline) || isBuffering) && <FullScreenLoadingIndicator style={[styles.opacity1, styles.bgTransparent]} />}
445-
{isLoading && !isBuffering && <AttachmentOfflineIndicator isPreview={isPreview} />}
445+
{isLoading && (isOffline || !isBuffering) && <AttachmentOfflineIndicator isPreview={isPreview} />}
446446
{controlStatusState !== CONST.VIDEO_PLAYER.CONTROLS_STATUS.HIDE && !isLoading && (isPopoverVisible || isHovered || canUseTouchScreen) && (
447447
<VideoPlayerControls
448448
duration={duration}

0 commit comments

Comments
 (0)