Skip to content

Commit 4d4edb1

Browse files
committed
Merge branch 'main' into fix/50577-inconsistent-money-request-and-task-behavior
2 parents f51fda8 + c3d33fc commit 4d4edb1

File tree

188 files changed

+4087
-2216
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

188 files changed

+4087
-2216
lines changed

.github/ISSUE_TEMPLATE/Standard.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ ___
1010
**Version Number:**
1111
**Reproducible in staging?:**
1212
**Reproducible in production?:**
13+
**If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:**
1314
**If this was caught during regression testing, add the test name, ID and link from TestRail:**
1415
**Email or phone of affected tester (no customers):**
1516
**Logs:** https://stackoverflow.com/c/expensify/questions/4856
@@ -34,9 +35,11 @@ Can the user still use Expensify without this being fixed? Have you informed the
3435
Check off any platforms that are affected by this issue
3536
--->
3637
Which of our officially supported platforms is this issue occurring on?
37-
- [ ] Android: Native
38+
- [ ] Android: Standalone
39+
- [ ] Android: HybridApp
3840
- [ ] Android: mWeb Chrome
39-
- [ ] iOS: Native
41+
- [ ] iOS: Standalone
42+
- [ ] iOS: HybridApp
4043
- [ ] iOS: mWeb Safari
4144
- [ ] MacOS: Chrome / Safari
4245
- [ ] MacOS: Desktop

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ android {
110110
minSdkVersion rootProject.ext.minSdkVersion
111111
targetSdkVersion rootProject.ext.targetSdkVersion
112112
multiDexEnabled rootProject.ext.multiDexEnabled
113-
versionCode 1009004901
114-
versionName "9.0.49-1"
113+
versionCode 1009005007
114+
versionName "9.0.50-7"
115115
// Supported language variants must be declared here to avoid from being removed during the compilation.
116116
// This also helps us to not include unnecessary language variants in the APK.
117117
resConfigs "en", "es"

docs/articles/expensify-classic/expensify-billing/Consolidated-Domain-Billing.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,12 @@ When a Domain Admin enables Consolidated Domain Billing, all Group workspaces ow
1616
If you don’t have multiple billing owners across your organization, or if you want to keep billing separate for any reason, then this feature isn’t necessary.
1717

1818
If you have an Annual Subscription and enable Consolidated Domain Billing, the Consolidated Domain Billing feature will gather the amounts due for each Group workspace Billing Owner (listed under **Settings > Workspaces > Group**). To make full use of the Annual Subscription for all workspaces in your domain, you should also be the billing owner for all Group workspaces.
19+
1920
{% include faq-begin.md %}
21+
2022
## How do I take over the billing of a workspace with Consolidated Domain Billing enabled?
2123
You’ll have to toggle off Consolidated Domain Billing, take over ownership of the workspace, and then toggle it back on.
24+
2225
## Can I use Consolidated Domain Billing to cover the bill for some workspaces, but not others?
2326
No, this feature means that you’ll be paying the bill for all domain members who choose a subscription.
2427

ios/NewExpensify/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<key>CFBundlePackageType</key>
2020
<string>APPL</string>
2121
<key>CFBundleShortVersionString</key>
22-
<string>9.0.49</string>
22+
<string>9.0.50</string>
2323
<key>CFBundleSignature</key>
2424
<string>????</string>
2525
<key>CFBundleURLTypes</key>
@@ -40,7 +40,7 @@
4040
</dict>
4141
</array>
4242
<key>CFBundleVersion</key>
43-
<string>9.0.49.1</string>
43+
<string>9.0.50.7</string>
4444
<key>FullStory</key>
4545
<dict>
4646
<key>OrgId</key>

ios/NewExpensifyTests/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
<key>CFBundlePackageType</key>
1616
<string>BNDL</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>9.0.49</string>
18+
<string>9.0.50</string>
1919
<key>CFBundleSignature</key>
2020
<string>????</string>
2121
<key>CFBundleVersion</key>
22-
<string>9.0.49.1</string>
22+
<string>9.0.50.7</string>
2323
</dict>
2424
</plist>

ios/NotificationServiceExtension/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
<key>CFBundleName</key>
1212
<string>$(PRODUCT_NAME)</string>
1313
<key>CFBundleShortVersionString</key>
14-
<string>9.0.49</string>
14+
<string>9.0.50</string>
1515
<key>CFBundleVersion</key>
16-
<string>9.0.49.1</string>
16+
<string>9.0.50.7</string>
1717
<key>NSExtension</key>
1818
<dict>
1919
<key>NSExtensionPointIdentifier</key>

ios/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1700,7 +1700,7 @@ PODS:
17001700
- ReactCommon/turbomodule/bridging
17011701
- ReactCommon/turbomodule/core
17021702
- Yoga
1703-
- react-native-keyboard-controller (1.14.0):
1703+
- react-native-keyboard-controller (1.14.1):
17041704
- DoubleConversion
17051705
- glog
17061706
- hermes-engine
@@ -3191,7 +3191,7 @@ SPEC CHECKSUMS:
31913191
react-native-geolocation: b9bd12beaf0ebca61a01514517ca8455bd26fa06
31923192
react-native-image-picker: f8a13ff106bcc7eb00c71ce11fdc36aac2a44440
31933193
react-native-key-command: aae312752fcdfaa2240be9a015fc41ce54087546
3194-
react-native-keyboard-controller: 17d5830f2bd6c6cad44682eb2cc13f9078eff985
3194+
react-native-keyboard-controller: 902c07f41a415b632583b384427a71770a8b02a3
31953195
react-native-launch-arguments: 5f41e0abf88a15e3c5309b8875d6fd5ac43df49d
31963196
react-native-netinfo: fb5112b1fa754975485884ae85a3fb6a684f49d5
31973197
react-native-pager-view: 94195f1bf32e7f78359fa20057c97e632364a08b

package-lock.json

Lines changed: 14 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "new.expensify",
3-
"version": "9.0.49-1",
3+
"version": "9.0.50-7",
44
"author": "Expensify, Inc.",
55
"homepage": "https://new.expensify.com",
66
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
@@ -156,7 +156,7 @@
156156
"react-native-permissions": "^3.10.0",
157157
"react-native-picker-select": "git+https://github.com/Expensify/react-native-picker-select.git#da50d2c5c54e268499047f9cc98b8df4196c1ddf",
158158
"react-native-plaid-link-sdk": "11.11.0",
159-
"react-native-qrcode-svg": "git+https://github.com/Expensify/react-native-qrcode-svg-old",
159+
"react-native-qrcode-svg": "6.3.11",
160160
"react-native-quick-sqlite": "git+https://github.com/margelo/react-native-quick-sqlite#99f34ebefa91698945f3ed26622e002bd79489e0",
161161
"react-native-reanimated": "3.15.1",
162162
"react-native-release-profiler": "^0.2.1",

src/CONST.ts

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,11 @@ import Config from 'react-native-config';
55
import * as KeyCommand from 'react-native-key-command';
66
import type {ValueOf} from 'type-fest';
77
import type {Video} from './libs/actions/Report';
8+
import type {MileageRate} from './libs/DistanceRequestUtils';
89
import BankAccount from './libs/models/BankAccount';
910
import * as Url from './libs/Url';
1011
import SCREENS from './SCREENS';
1112
import type PlaidBankAccount from './types/onyx/PlaidBankAccount';
12-
import type {Unit} from './types/onyx/Policy';
13-
14-
type RateAndUnit = {
15-
unit: Unit;
16-
rate: number;
17-
currency: string;
18-
};
19-
type CurrencyDefaultMileageRate = Record<string, RateAndUnit>;
2013

2114
// Creating a default array and object this way because objects ({}) and arrays ([]) are not stable types.
2215
// Freezing the array ensures that it cannot be unintentionally modified.
@@ -745,6 +738,7 @@ const CONST = {
745738
HOW_TO_CONNECT_TO_SAGE_INTACCT: 'https://help.expensify.com/articles/expensify-classic/integrations/accounting-integrations/Sage-Intacct#how-to-connect-to-sage-intacct',
746739
PRICING: `https://www.expensify.com/pricing`,
747740
COMPANY_CARDS_HELP: 'https://help.expensify.com/articles/expensify-classic/connect-credit-cards/company-cards/Commercial-Card-Feeds',
741+
COMPANY_CARDS_STRIPE_HELP: 'https://dashboard.stripe.com/login?redirect=%2Fexpenses%2Fsettings',
748742
COMPANY_CARDS_CONNECT_CREDIT_CARDS_HELP_URL:
749743
'https://help.expensify.com/articles/expensify-classic/connect-credit-cards/company-cards/Commercial-Card-Feeds#what-is-the-difference-between-commercial-card-feeds-and-your-direct-bank-connections',
750744
CUSTOM_REPORT_NAME_HELP_URL: 'https://help.expensify.com/articles/expensify-classic/spending-insights/Custom-Templates',
@@ -753,6 +747,11 @@ const CONST = {
753747
DELAYED_SUBMISSION_HELP_URL: 'https://help.expensify.com/articles/expensify-classic/reports/Automatically-submit-employee-reports',
754748
// Use Environment.getEnvironmentURL to get the complete URL with port number
755749
DEV_NEW_EXPENSIFY_URL: 'https://dev.new.expensify.com:',
750+
NAVATTIC: {
751+
ADMIN_TOUR: 'https://expensify.navattic.com/kh204a7',
752+
EMPLOYEE_TOUR: 'https://expensify.navattic.com/35609gb',
753+
},
754+
756755
OLDDOT_URLS: {
757756
ADMIN_POLICIES_URL: 'admin_policies',
758757
ADMIN_DOMAINS_URL: 'admin_domains',
@@ -824,6 +823,7 @@ const CONST = {
824823
CARD_MISSING_ADDRESS: 'CARDMISSINGADDRESS',
825824
CARD_ISSUED: 'CARDISSUED',
826825
CARD_ISSUED_VIRTUAL: 'CARDISSUEDVIRTUAL',
826+
CARD_ASSIGNED: 'CARDASSIGNED',
827827
CHANGE_FIELD: 'CHANGEFIELD', // OldDot Action
828828
CHANGE_POLICY: 'CHANGEPOLICY', // OldDot Action
829829
CHANGE_TYPE: 'CHANGETYPE', // OldDot Action
@@ -1108,7 +1108,7 @@ const CONST = {
11081108
},
11091109
TIMING: {
11101110
CALCULATE_MOST_RECENT_LAST_MODIFIED_ACTION: 'calc_most_recent_last_modified_action',
1111-
CHAT_FINDER_RENDER: 'search_render',
1111+
SEARCH_ROUTER_RENDER: 'search_router_render',
11121112
CHAT_RENDER: 'chat_render',
11131113
OPEN_REPORT: 'open_report',
11141114
HOMEPAGE_INITIAL_RENDER: 'homepage_initial_render',
@@ -1130,6 +1130,9 @@ const CONST = {
11301130
SEARCH_OPTION_LIST_DEBOUNCE_TIME: 300,
11311131
RESIZE_DEBOUNCE_TIME: 100,
11321132
UNREAD_UPDATE_DEBOUNCE_TIME: 300,
1133+
SEARCH_CONVERT_SEARCH_VALUES: 'search_convert_search_values',
1134+
SEARCH_MAKE_TREE: 'search_make_tree',
1135+
SEARCH_BUILD_TREE: 'search_build_tree',
11331136
SEARCH_FILTER_OPTIONS: 'search_filter_options',
11341137
USE_DEBOUNCED_STATE_DELAY: 300,
11351138
},
@@ -1492,9 +1495,12 @@ const CONST = {
14921495
MARK_CHECKS_TO_BE_PRINTED: 'markChecksToBePrinted',
14931496
REIMBURSABLE_ACCOUNT: 'reimbursableAccount',
14941497
REIMBURSABLE: 'reimbursable',
1498+
AUTO_SYNC: 'autoSync',
14951499
ENABLE_NEW_CATEGORIES: 'enableNewCategories',
1500+
SHOULD_AUTO_CREATE_VENDOR: 'shouldAutoCreateVendor',
14961501
MAPPINGS: {
14971502
CLASSES: 'classes',
1503+
CUSTOMERS: 'customers',
14981504
},
14991505
},
15001506

@@ -2462,6 +2468,8 @@ const CONST = {
24622468
DEFAULT_RATE: 'Default Rate',
24632469
RATE_DECIMALS: 3,
24642470
FAKE_P2P_ID: '_FAKE_P2P_ID_',
2471+
MILES_TO_KILOMETERS: 1.609344,
2472+
KILOMETERS_TO_MILES: 0.621371,
24652473
},
24662474

24672475
TERMS: {
@@ -2505,6 +2513,7 @@ const CONST = {
25052513
MASTER_CARD: 'cdf',
25062514
VISA: 'vcf',
25072515
AMEX: 'gl1025',
2516+
STRIPE: 'stripe',
25082517
},
25092518
STEP_NAMES: ['1', '2', '3', '4'],
25102519
STEP: {
@@ -2575,6 +2584,7 @@ const CONST = {
25752584
AMEX: 'amex',
25762585
VISA: 'visa',
25772586
MASTERCARD: 'mastercard',
2587+
STRIPE: 'stripe',
25782588
},
25792589
FEED_TYPE: {
25802590
CUSTOM: 'customFeed',
@@ -2902,6 +2912,7 @@ const CONST = {
29022912
SETTINGS: 'settings',
29032913
LEAVE_ROOM: 'leaveRoom',
29042914
PRIVATE_NOTES: 'privateNotes',
2915+
DOWNLOAD: 'download',
29052916
EXPORT: 'export',
29062917
DELETE: 'delete',
29072918
MARK_AS_INCOMPLETE: 'markAsIncomplete',
@@ -5520,7 +5531,7 @@ const CONST = {
55205531
"rate": 2377,
55215532
"unit": "km"
55225533
}
5523-
}`) as CurrencyDefaultMileageRate,
5534+
}`) as Record<string, MileageRate>,
55245535

55255536
EXIT_SURVEY: {
55265537
REASONS: {
@@ -5678,7 +5689,6 @@ const CONST = {
56785689
KEYWORD: 'keyword',
56795690
IN: 'in',
56805691
},
5681-
EMPTY_VALUE: 'none',
56825692
},
56835693

56845694
REFERRER: {
@@ -5915,7 +5925,6 @@ export type {
59155925
Country,
59165926
IOUAction,
59175927
IOUType,
5918-
RateAndUnit,
59195928
OnboardingPurposeType,
59205929
OnboardingCompanySizeType,
59215930
IOURequestType,

0 commit comments

Comments
 (0)