Merge pull request #19749 from dhairyasenjaliya/taskDescription

Remove Mandatory Description field on edit task

Author: Joel Bettner

src/libs/actions/Task.js

@@ -325,7 +325,7 @@ function editTaskAndNavigate(report, ownerEmail, title, description, assignee) {
             key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
             value: {
                 reportName,
-                description: (description || report.description).trim(),
+                description: description.trim(),
                 managerEmail: assignee || report.managerEmail,
             },
         },
@@ -380,7 +380,7 @@ function editTaskAndNavigate(report, ownerEmail, title, description, assignee) {
         {
             taskReportID: report.reportID,
             title: reportName,
-            description: (description || report.description).trim(),
+            description: description.trim(),
             assignee: assignee || report.assignee,
             editedTaskReportActionID: editTaskReportAction.reportActionID,
             assigneeChatReportActionID: optimisticAssigneeAddComment ? optimisticAssigneeAddComment.reportAction.reportActionID : 0,

src/pages/tasks/NewTaskDescriptionPage.js

@@ -43,6 +43,7 @@ const NewTaskDescriptionPage = (props) => {
      * @returns {Object}
      */
     function validate() {
+        // This field is optional and can be left blank, so we should not require validation for its value.
         return {};
     }
 
@@ -86,7 +87,7 @@ const NewTaskDescriptionPage = (props) => {
                     <TextInput
                         defaultValue={props.task.description}
                         inputID="taskDescription"
-                        label={props.translate('newTaskPage.description')}
+                        label={props.translate('newTaskPage.descriptionOptional')}
                         ref={(el) => (inputRef.current = el)}
                     />
                 </View>

src/pages/tasks/TaskDescriptionPage.js

@@ -1,4 +1,3 @@
-import _ from 'underscore';
 import React, {useCallback, useRef} from 'react';
 import PropTypes from 'prop-types';
 import {View} from 'react-native';
@@ -37,23 +36,7 @@ const defaultProps = {
 };
 
 function TaskDescriptionPage(props) {
-    /**
-     * @param {Object} values
-     * @param {String} values.description
-     * @returns {Object} - An object containing the errors for each inputID
-     */
-    const validate = useCallback(
-        (values) => {
-            const errors = {};
-
-            if (_.isEmpty(values.description)) {
-                errors.description = props.translate('common.error.fieldRequired');
-            }
-
-            return errors;
-        },
-        [props],
-    );
+    const validate = useCallback(() => ({}), []);
 
     const submit = useCallback(
         (values) => {
@@ -89,7 +72,7 @@ function TaskDescriptionPage(props) {
                     <TextInput
                         inputID="description"
                         name="description"
-                        label={props.translate('newTaskPage.description')}
+                        label={props.translate('newTaskPage.descriptionOptional')}
                         defaultValue={(props.task.report && props.task.report.description) || ''}
                         ref={(el) => (inputRef.current = el)}
                     />