Merge pull request #51566 from Expensify/jules-fixOldDotActionCrash

mountiny · web-flow · commit 3383125530c0 · 2024-10-28T14:22:46.000+01:00
[NO QA] Prevent HybridApp crash when action without actionName is copied to clipboard
diff --git a/src/libs/ReportActionsUtils.ts b/src/libs/ReportActionsUtils.ts
@@ -1227,6 +1227,9 @@ function isOldDotLegacyAction(action: OldDotReportAction | PartialReportAction):
 }
 
 function isOldDotReportAction(action: ReportAction | OldDotReportAction) {
+    if (!action || !action.actionName) {
+        return false;
+    }
     return [
         CONST.REPORT.ACTIONS.TYPE.CHANGE_FIELD,
         CONST.REPORT.ACTIONS.TYPE.CHANGE_POLICY,

Original file line number	Diff line number	Diff line change
`@@ -1227,6 +1227,9 @@ function isOldDotLegacyAction(action: OldDotReportAction \| PartialReportAction):`
`1227`	`1227`	`}`
`1228`	`1228`
`1229`	`1229`	`function isOldDotReportAction(action: ReportAction \| OldDotReportAction) {`
	`1230`	`+ if (!action \|\| !action.actionName) {`
	`1231`	`+ return false;`
	`1232`	`+ }`
`1230`	`1233`	`return [`
`1231`	`1234`	`CONST.REPORT.ACTIONS.TYPE.CHANGE_FIELD,`
`1232`	`1235`	`CONST.REPORT.ACTIONS.TYPE.CHANGE_POLICY,`