Skip to content

Commit 2f7f97f

Browse files
committed
fix: /SearchForReports call missing for narrow resolutions
1 parent 83d600e commit 2f7f97f

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

src/components/Search/SearchPageHeader/SearchPageHeader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ type SearchPageHeaderProps = {
2828
hideSearchRouterList?: () => void;
2929
onSearchRouterFocus?: () => void;
3030
headerButtonsOptions: Array<DropdownOption<SearchHeaderOptionValue>>;
31-
handleSearch?: (value: string) => void;
31+
handleSearch: (value: string) => void;
3232
};
3333

3434
type SearchHeaderOptionValue = DeepValueOf<typeof CONST.SEARCH.BULK_ACTION_TYPES> | undefined;

src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ type SearchPageHeaderInputProps = {
5050
onSearchRouterFocus?: () => void;
5151
searchName?: string;
5252
inputRightComponent: React.ReactNode;
53-
handleSearch?: (value: string) => void;
53+
handleSearch: (value: string) => void;
5454
};
5555

5656
function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRouterList, onSearchRouterFocus, searchName, inputRightComponent, handleSearch}: SearchPageHeaderInputProps) {
@@ -141,7 +141,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
141141
const handleSearchAction = useCallback(
142142
(value: string) => {
143143
// Skip calling handleSearch on the initial mount
144-
if (!hasMountedRef.current || !handleSearch) {
144+
if (!hasMountedRef.current) {
145145
return;
146146
}
147147
handleSearch(value);

src/components/Search/index.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ type SearchProps = {
5656
contentContainerStyle?: StyleProp<ViewStyle>;
5757
currentSearchResults?: SearchResults;
5858
lastNonEmptySearchResults?: SearchResults;
59-
handleSearch?: (value: SearchParams) => void;
59+
handleSearch: (value: SearchParams) => void;
6060
};
6161

6262
function mapTransactionItemToSelectedEntry(item: TransactionListItemType): [string, SelectedTransactionInfo] {
@@ -202,10 +202,6 @@ function Search({queryJSON, currentSearchResults, lastNonEmptySearchResults, onS
202202
return;
203203
}
204204

205-
if (!handleSearch) {
206-
return;
207-
}
208-
209205
handleSearch({queryJSON, offset});
210206
}, [handleSearch, isOffline, offset, queryJSON]);
211207

src/pages/Search/SearchPageNarrow.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ function SearchPageNarrow({queryJSON, searchName, headerButtonsOptions, currentS
171171
setSearchRouterListVisible(true);
172172
}}
173173
headerButtonsOptions={headerButtonsOptions}
174+
handleSearch={handleSearchAction}
174175
/>
175176
</View>
176177
<View style={[styles.appBG]}>
@@ -201,6 +202,7 @@ function SearchPageNarrow({queryJSON, searchName, headerButtonsOptions, currentS
201202
queryJSON={queryJSON}
202203
searchName={searchName}
203204
headerButtonsOptions={headerButtonsOptions}
205+
handleSearch={handleSearchAction}
204206
/>
205207
</>
206208
)}

0 commit comments

Comments
 (0)