Merge pull request #5036 from Expensify/andrew-ios-prod

[No QA]Fix iOS production deploys

Author: roryabraham

.github/workflows/platformDeploy.yml

@@ -243,9 +243,7 @@ jobs:
 
       - name: Set iOS version in ENV
         if: ${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
-        run: |
-          echo "IOS_VERSION=$(echo '${{ github.event.release.tag_name }}' | tr '-' '.')" >> $GITHUB_ENV
-          echo "iOS version is: ${{ env.IOS_VERSION }}"
+        run: echo "IOS_VERSION=$(echo '${{ github.event.release.tag_name }}' | tr '-' '.')" >> $GITHUB_ENV
 
       - name: Run Fastlane for App Store release
         if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }}

Gemfile.lock

@@ -14,21 +14,21 @@ GEM
       json (>= 1.5.1)
     artifactory (3.0.15)
     atomos (0.1.3)
-    aws-eventstream (1.1.1)
-    aws-partitions (1.490.0)
-    aws-sdk-core (3.119.1)
+    aws-eventstream (1.2.0)
+    aws-partitions (1.495.0)
+    aws-sdk-core (3.121.0)
       aws-eventstream (~> 1, >= 1.0.2)
       aws-partitions (~> 1, >= 1.239.0)
       aws-sigv4 (~> 1.1)
       jmespath (~> 1.0)
-    aws-sdk-kms (1.46.0)
-      aws-sdk-core (~> 3, >= 3.119.0)
+    aws-sdk-kms (1.48.0)
+      aws-sdk-core (~> 3, >= 3.120.0)
       aws-sigv4 (~> 1.1)
-    aws-sdk-s3 (1.99.0)
-      aws-sdk-core (~> 3, >= 3.119.0)
+    aws-sdk-s3 (1.102.0)
+      aws-sdk-core (~> 3, >= 3.120.0)
       aws-sdk-kms (~> 1)
-      aws-sigv4 (~> 1.1)
-    aws-sigv4 (1.2.4)
+      aws-sigv4 (~> 1.4)
+    aws-sigv4 (1.4.0)
       aws-eventstream (~> 1, >= 1.0.2)
     babosa (1.0.4)
     claide (1.0.3)
@@ -85,7 +85,7 @@ GEM
     ethon (0.12.0)
       ffi (>= 1.3.0)
     excon (0.85.0)
-    faraday (1.7.0)
+    faraday (1.7.1)
       faraday-em_http (~> 1.0)
       faraday-em_synchrony (~> 1.0)
       faraday-excon (~> 1.1)
@@ -110,7 +110,7 @@ GEM
     faraday_middleware (1.1.0)
       faraday (~> 1.0)
     fastimage (2.2.5)
-    fastlane (2.192.0)
+    fastlane (2.193.1)
       CFPropertyList (>= 2.3, < 4.0.0)
       addressable (>= 2.8, < 3.0.0)
       artifactory (~> 3.0)
@@ -184,13 +184,13 @@ GEM
       google-cloud-core (~> 1.6)
       googleauth (>= 0.16.2, < 2.a)
       mini_mime (~> 1.0)
-    googleauth (0.17.0)
+    googleauth (0.17.1)
       faraday (>= 0.17.3, < 2.0)
       jwt (>= 1.4, < 3.0)
       memoist (~> 0.16)
       multi_json (~> 1.11)
       os (>= 0.9, < 2.0)
-      signet (~> 0.14)
+      signet (~> 0.15)
     highline (2.0.3)
     http-cookie (1.0.4)
       domain_name (~> 0.5)

fastlane/Fastfile

@@ -140,16 +140,62 @@ platform :ios do
   lane :production do
     deliver(
       api_key_path: "./ios/ios-fastlane-json-key.json",
+
+      # Skip HTMl report verification
+      force: true, 
+
+      # VERSION will be set to the full build_number e.g. '1.0.92.0'
       build_number: ENV["VERSION"],
+
+      # app_version needs to be set to the short version, without the last digit e.g. '1.0.92'
+      app_version: ENV["VERSION"].rpartition(".")[0],
+
+      # We want to submit the version for Apple to review
       submit_for_review: true,
+
+      # We want to release the app as soon as it's approved
       automatic_release: true,
-      skip_metadata: true,
+
+      # We need to upload metadata to upload the release notes which is required for rach new version
+      skip_metadata: false,
+
+      # We do not want to upload any screenshots
       skip_screenshots: true,
+
+      # We do not have any binary to upload as it's already in TestFlight
       skip_binary_upload: true,
+
+      # Reject the current build if there is one in review
+      reject_if_possible: true,
+
+      # We do not want to reset the ratings
+      reset_ratings: false,
+
+      # Precheck cannot check for in app purchases with the API key we use
       precheck_include_in_app_purchases: false,
       submission_information: {
-        add_id_info_uses_idfa: false
+
+        # We currently do not use idfa: https://developer.apple.com/app-store/user-privacy-and-data-use/
+        add_id_info_uses_idfa: false,
+
+        # We do not need any additional compliance
+        export_compliance_compliance_required: false,
+
+        # We do not use any encrpytion
+        export_compliance_encryption_updated: false,
+        export_compliance_app_type: nil,
+        export_compliance_uses_encryption: false,
+        export_compliance_is_exempt: false,
+        export_compliance_contains_third_party_cryptography: false,
+        export_compliance_contains_proprietary_cryptography: false,
+
+        # We do not show any third party content
+        content_rights_contains_third_party_content: false
+      },
+      release_notes: {
+        'en-US' => "Improvements and bug fixes"
       }
     )
+
   end
 end