Skip to content

Commit 134d5d4

Browse files
deetergpdeetergp
authored
Merge pull request #53521 from nkdengineer/fix/52633
fix: App crashes when clicking on search icon while app is loading
2 parents d9be98d + e8cfa64 commit 134d5d4

15 files changed

+42
-55
lines changed

‎src/components/OptionListContextProvider.tsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import usePrevious from '@hooks/usePrevious';
44
import * as OptionsListUtils from '@libs/OptionsListUtils';
55
import type {OptionList} from '@libs/OptionsListUtils';
66
import * as ReportUtils from '@libs/ReportUtils';
7-
import CONST from '@src/CONST';
87
import ONYXKEYS from '@src/ONYXKEYS';
98
import type {PersonalDetails, Report} from '@src/types/onyx';
109
import {usePersonalDetails} from './OnyxProvider';
@@ -35,7 +34,7 @@ const OptionsListContext = createContext<OptionsListContextProps>({
3534
resetOptions: () => {},
3635
});
3736

38-
const isEqualPersonalDetail = (prevPersonalDetail: PersonalDetails | null, personalDetail: PersonalDetails | null) =>
37+
const isEqualPersonalDetail = (prevPersonalDetail: PersonalDetails, personalDetail: PersonalDetails) =>
3938
prevPersonalDetail?.firstName === personalDetail?.firstName &&
4039
prevPersonalDetail?.lastName === personalDetail?.lastName &&
4140
prevPersonalDetail?.login === personalDetail?.login &&
@@ -49,7 +48,7 @@ function OptionsListContextProvider({children}: OptionsListProviderProps) {
4948
});
5049
const [reports] = useOnyx(ONYXKEYS.COLLECTION.REPORT);
5150

52-
const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;
51+
const personalDetails = usePersonalDetails();
5352
const prevPersonalDetails = usePrevious(personalDetails);
5453

5554
/**
@@ -83,16 +82,20 @@ function OptionsListContextProvider({children}: OptionsListProviderProps) {
8382
return;
8483
}
8584

85+
if (!personalDetails) {
86+
return;
87+
}
88+
8689
const newReportOptions: Array<{
8790
replaceIndex: number;
8891
newReportOption: OptionsListUtils.SearchOption<Report>;
8992
}> = [];
9093

9194
Object.keys(personalDetails).forEach((accountID) => {
9295
const prevPersonalDetail = prevPersonalDetails?.[accountID];
93-
const personalDetail = personalDetails?.[accountID];
96+
const personalDetail = personalDetails[accountID];
9497

95-
if (isEqualPersonalDetail(prevPersonalDetail, personalDetail)) {
98+
if (prevPersonalDetail && personalDetail && isEqualPersonalDetail(prevPersonalDetail, personalDetail)) {
9699
return;
97100
}
98101

‎src/components/ReportActionItem/TaskView.tsx

Lines changed: 7 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import React, {useEffect} from 'react';
22
import {View} from 'react-native';
3-
import {withOnyx} from 'react-native-onyx';
4-
import type {OnyxEntry} from 'react-native-onyx';
53
import Checkbox from '@components/Checkbox';
64
import Hoverable from '@components/Hoverable';
75
import Icon from '@components/Icon';
@@ -26,31 +24,24 @@ import * as TaskUtils from '@libs/TaskUtils';
2624
import * as Session from '@userActions/Session';
2725
import * as Task from '@userActions/Task';
2826
import CONST from '@src/CONST';
29-
import ONYXKEYS from '@src/ONYXKEYS';
3027
import ROUTES from '@src/ROUTES';
31-
import type {PersonalDetailsList, Report} from '@src/types/onyx';
28+
import type {Report} from '@src/types/onyx';
3229

33-
type TaskViewOnyxProps = {
34-
/** All of the personal details for everyone */
35-
personalDetails: OnyxEntry<PersonalDetailsList>;
30+
type TaskViewProps = WithCurrentUserPersonalDetailsProps & {
31+
/** The report currently being looked at */
32+
report: Report;
3633
};
3734

38-
type TaskViewProps = TaskViewOnyxProps &
39-
WithCurrentUserPersonalDetailsProps & {
40-
/** The report currently being looked at */
41-
report: Report;
42-
};
43-
4435
function TaskView({report, ...props}: TaskViewProps) {
4536
const styles = useThemeStyles();
4637
const StyleUtils = useStyleUtils();
4738
useEffect(() => {
4839
Task.setTaskReport(report);
4940
}, [report]);
50-
41+
const personalDetails = usePersonalDetails();
5142
const taskTitle = convertToLTR(report.reportName ?? '');
5243
const assigneeTooltipDetails = ReportUtils.getDisplayNamesWithTooltips(
53-
OptionsListUtils.getPersonalDetailsForAccountIDs(report.managerID ? [report.managerID] : [], props.personalDetails),
44+
OptionsListUtils.getPersonalDetailsForAccountIDs(report.managerID ? [report.managerID] : [], personalDetails),
5445
false,
5546
);
5647
const isCompleted = ReportUtils.isCompletedTaskReport(report);
@@ -59,7 +50,6 @@ function TaskView({report, ...props}: TaskViewProps) {
5950
const canActionTask = Task.canActionTask(report, props.currentUserPersonalDetails.accountID);
6051
const disableState = !canModifyTask;
6152
const isDisableInteractive = !canModifyTask || !isOpen;
62-
const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;
6353
const {translate} = useLocalize();
6454

6555
return (
@@ -190,10 +180,4 @@ function TaskView({report, ...props}: TaskViewProps) {
190180

191181
TaskView.displayName = 'TaskView';
192182

193-
const TaskViewWithOnyx = withOnyx<TaskViewProps, TaskViewOnyxProps>({
194-
personalDetails: {
195-
key: ONYXKEYS.PERSONAL_DETAILS_LIST,
196-
},
197-
})(TaskView);
198-
199-
export default withCurrentUserPersonalDetails(TaskViewWithOnyx);
183+
export default withCurrentUserPersonalDetails(TaskView);

‎src/components/Search/SearchRouter/buildSubstitutionsMap.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const getSubstitutionsKey = (filterKey: SearchFilterKey, value: string) => `${fi
2626
*/
2727
function buildSubstitutionsMap(
2828
query: string,
29-
personalDetails: OnyxTypes.PersonalDetailsList,
29+
personalDetails: OnyxTypes.PersonalDetailsList | undefined,
3030
reports: OnyxCollection<OnyxTypes.Report>,
3131
allTaxRates: Record<string, string[]>,
3232
): SubstitutionMap {

‎src/components/createOnyxContext.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ type CreateOnyxContext<TOnyxKey extends OnyxKey> = [
3333
WithOnyxKey<TOnyxKey>,
3434
ComponentType<Omit<ProviderPropsWithOnyx<TOnyxKey>, TOnyxKey>>,
3535
React.Context<OnyxValue<TOnyxKey>>,
36-
() => NonNullable<OnyxValue<TOnyxKey>>,
36+
() => OnyxValue<TOnyxKey>,
3737
];
3838

3939
export default <TOnyxKey extends OnyxKey>(onyxKeyName: TOnyxKey): CreateOnyxContext<TOnyxKey> => {
@@ -43,7 +43,7 @@ export default <TOnyxKey extends OnyxKey>(onyxKeyName: TOnyxKey): CreateOnyxCont
4343
}
4444

4545
Provider.displayName = `${Str.UCFirst(onyxKeyName)}Provider`;
46-
46+
// eslint-disable-next-line
4747
const ProviderWithOnyx = withOnyx<ProviderPropsWithOnyx<TOnyxKey>, ProviderOnyxProps<TOnyxKey>>({
4848
[onyxKeyName]: {
4949
key: onyxKeyName,
@@ -87,7 +87,7 @@ export default <TOnyxKey extends OnyxKey>(onyxKeyName: TOnyxKey): CreateOnyxCont
8787
if (value === null) {
8888
throw new Error(`useOnyxContext must be used within a OnyxProvider [key: ${onyxKeyName}]`);
8989
}
90-
return value as NonNullable<OnyxValue<TOnyxKey>>;
90+
return value as OnyxValue<TOnyxKey>;
9191
};
9292

9393
return [withOnyxKey, ProviderWithOnyx, Context, useOnyxContext];

‎src/libs/SearchQueryUtils.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ function buildFilterFormValuesFromQuery(
376376
policyCategories: OnyxCollection<OnyxTypes.PolicyCategories>,
377377
policyTags: OnyxCollection<OnyxTypes.PolicyTagLists>,
378378
currencyList: OnyxTypes.CurrencyList,
379-
personalDetails: OnyxTypes.PersonalDetailsList,
379+
personalDetails: OnyxTypes.PersonalDetailsList | undefined,
380380
cardList: OnyxTypes.CardList,
381381
reports: OnyxCollection<OnyxTypes.Report>,
382382
taxRates: Record<string, string[]>,
@@ -406,7 +406,7 @@ function buildFilterFormValuesFromQuery(
406406
filtersForm[filterKey] = filterValues.filter((id) => reports?.[`${ONYXKEYS.COLLECTION.REPORT}${id}`]?.reportID);
407407
}
408408
if (filterKey === CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM || filterKey === CONST.SEARCH.SYNTAX_FILTER_KEYS.TO) {
409-
filtersForm[filterKey] = filterValues.filter((id) => personalDetails[id]);
409+
filtersForm[filterKey] = filterValues.filter((id) => personalDetails && personalDetails[id]);
410410
}
411411
if (filterKey === CONST.SEARCH.SYNTAX_FILTER_KEYS.CURRENCY) {
412412
const validCurrency = new Set(Object.keys(currencyList));
@@ -504,7 +504,7 @@ function getPolicyIDFromSearchQuery(queryJSON: SearchQueryJSON) {
504504
/**
505505
* Returns the human-readable "pretty" string for a specified filter value.
506506
*/
507-
function getFilterDisplayValue(filterName: string, filterValue: string, personalDetails: OnyxTypes.PersonalDetailsList, reports: OnyxCollection<OnyxTypes.Report>) {
507+
function getFilterDisplayValue(filterName: string, filterValue: string, personalDetails: OnyxTypes.PersonalDetailsList | undefined, reports: OnyxCollection<OnyxTypes.Report>) {
508508
if (filterName === CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM || filterName === CONST.SEARCH.SYNTAX_FILTER_KEYS.TO) {
509509
// login can be an empty string
510510
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
@@ -535,7 +535,7 @@ function getFilterDisplayValue(filterName: string, filterValue: string, personal
535535
*/
536536
function buildUserReadableQueryString(
537537
queryJSON: SearchQueryJSON,
538-
PersonalDetails: OnyxTypes.PersonalDetailsList,
538+
PersonalDetails: OnyxTypes.PersonalDetailsList | undefined,
539539
reports: OnyxCollection<OnyxTypes.Report>,
540540
taxRates: Record<string, string[]>,
541541
) {

‎src/pages/RoomMembersPage.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function RoomMembersPage({report, policies}: RoomMembersPageProps) {
5555
const [userSearchPhrase] = useOnyx(ONYXKEYS.ROOM_MEMBERS_USER_SEARCH_PHRASE);
5656
const [searchValue, setSearchValue] = useState('');
5757
const [didLoadRoomMembers, setDidLoadRoomMembers] = useState(false);
58-
const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;
58+
const personalDetails = usePersonalDetails();
5959
const policy = useMemo(() => policies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID ?? ''}`], [policies, report?.policyID]);
6060
const isPolicyExpenseChat = useMemo(() => ReportUtils.isPolicyExpenseChat(report), [report]);
6161
const backTo = route.params.backTo;
@@ -212,7 +212,7 @@ function RoomMembersPage({report, policies}: RoomMembersPageProps) {
212212
let result: ListItem[] = [];
213213

214214
participants.forEach((accountID) => {
215-
const details = personalDetails[accountID];
215+
const details = personalDetails?.[accountID];
216216

217217
// If search value is provided, filter out members that don't match the search value
218218
if (!details || (searchValue.trim() && !OptionsListUtils.isSearchStringMatchUserDetails(details, searchValue))) {

‎src/pages/Search/AdvancedSearchFilters.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,8 @@ function getFilterCardDisplayTitle(filters: Partial<SearchAdvancedFiltersForm>,
221221
: undefined;
222222
}
223223

224-
function getFilterParticipantDisplayTitle(accountIDs: string[], personalDetails: PersonalDetailsList) {
225-
const selectedPersonalDetails = accountIDs.map((id) => personalDetails[id]);
224+
function getFilterParticipantDisplayTitle(accountIDs: string[], personalDetails: PersonalDetailsList | undefined) {
225+
const selectedPersonalDetails = accountIDs.map((id) => personalDetails?.[id]);
226226

227227
return selectedPersonalDetails
228228
.map((personalDetail) => {

‎src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ function ReportActionCompose({
124124
const {isOffline} = useNetwork();
125125
const actionButtonRef = useRef<View | HTMLDivElement | null>(null);
126126
const currentUserPersonalDetails = useCurrentUserPersonalDetails();
127-
const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;
127+
const personalDetails = usePersonalDetails();
128128
const navigation = useNavigation();
129129
const [blockedFromConcierge] = useOnyx(ONYXKEYS.NVP_BLOCKED_FROM_CONCIERGE);
130130
const [shouldShowComposeInput = true] = useOnyx(ONYXKEYS.SHOULD_SHOW_COMPOSE_INPUT);
@@ -342,7 +342,7 @@ function ReportActionCompose({
342342
// When we invite someone to a room they don't have the policy object, but we still want them to be able to mention other reports they are members of, so we only check if the policyID in the report is from a workspace
343343
const isGroupPolicyReport = useMemo(() => !!report?.policyID && report.policyID !== CONST.POLICY.ID_FAKE, [report]);
344344
const reportRecipientAcountIDs = ReportUtils.getReportRecipientAccountIDs(report, currentUserPersonalDetails.accountID);
345-
const reportRecipient = personalDetails[reportRecipientAcountIDs[0]];
345+
const reportRecipient = personalDetails?.[reportRecipientAcountIDs[0]];
346346
const shouldUseFocusedColor = !isBlockedFromConcierge && !disabled && isFocused;
347347

348348
const hasReportRecipient = !isEmptyObject(reportRecipient);

‎src/pages/home/report/ReportActionCompose/SuggestionMention.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ function SuggestionMention(
8585
{value, selection, setSelection, updateComment, isAutoSuggestionPickerLarge, measureParentContainerAndReportCursor, isComposerFocused, isGroupPolicyReport, policyID}: SuggestionProps,
8686
ref: ForwardedRef<SuggestionsRef>,
8787
) {
88-
const personalDetails = usePersonalDetails() ?? CONST.EMPTY_OBJECT;
88+
const personalDetails = usePersonalDetails();
8989
const {translate, formatPhoneNumber} = useLocalize();
9090
const [suggestionValues, setSuggestionValues] = useState(defaultSuggestionsValues);
9191
const suggestionValuesRef = useRef(suggestionValues);
@@ -112,7 +112,7 @@ function SuggestionMention(
112112
},
113113
[currentReport],
114114
);
115-
const weightedPersonalDetails: PersonalDetailsList | SuggestionPersonalDetailsList = useMemo(() => {
115+
const weightedPersonalDetails: PersonalDetailsList | SuggestionPersonalDetailsList | undefined = useMemo(() => {
116116
const policyEmployeeAccountIDs = getPolicyEmployeeAccountIDs(policyID);
117117
if (!ReportUtils.isGroupChat(currentReport) && !ReportUtils.doesReportBelongToWorkspace(currentReport, policyEmployeeAccountIDs, policyID)) {
118118
return personalDetails;
@@ -264,7 +264,7 @@ function SuggestionMention(
264264
);
265265

266266
const getUserMentionOptions = useCallback(
267-
(personalDetailsParam: PersonalDetailsList | SuggestionPersonalDetailsList, searchValue = ''): Mention[] => {
267+
(personalDetailsParam: PersonalDetailsList | SuggestionPersonalDetailsList | undefined, searchValue = ''): Mention[] => {
268268
const suggestions = [];
269269

270270
if (CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT.includes(searchValue.toLowerCase())) {

‎src/pages/home/report/ReportActionItem.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ function ReportActionItem({
187187
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- This is needed to prevent the app from crashing when the app is using imported state.
188188
const [reportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID || '-1'}`);
189189
const StyleUtils = useStyleUtils();
190-
const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;
190+
const personalDetails = usePersonalDetails();
191191
const [isContextMenuActive, setIsContextMenuActive] = useState(() => ReportActionContextMenu.isActiveReportAction(action.reportActionID));
192192
const [isEmojiPickerActive, setIsEmojiPickerActive] = useState<boolean | undefined>();
193193
const [isPaymentMethodPopoverActive, setIsPaymentMethodPopoverActive] = useState<boolean | undefined>();
@@ -603,7 +603,7 @@ function ReportActionItem({
603603
);
604604
} else if (ReportActionsUtils.isReimbursementQueuedAction(action)) {
605605
const linkedReport = ReportUtils.isChatThread(report) ? parentReport : report;
606-
const submitterDisplayName = PersonalDetailsUtils.getDisplayNameOrDefault(personalDetails[linkedReport?.ownerAccountID ?? -1]);
606+
const submitterDisplayName = PersonalDetailsUtils.getDisplayNameOrDefault(personalDetails?.[linkedReport?.ownerAccountID ?? -1]);
607607
const paymentType = ReportActionsUtils.getOriginalMessage(action)?.paymentType ?? '';
608608

609609
const missingPaymentMethod = ReportUtils.getIndicatedMissingPaymentMethod(userWallet, linkedReport?.reportID ?? '-1', action);

‎src/pages/home/report/ReportActionItemSingle.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,16 +82,16 @@ function ReportActionItemSingle({
8282
const styles = useThemeStyles();
8383
const StyleUtils = useStyleUtils();
8484
const {translate} = useLocalize();
85-
const personalDetails = usePersonalDetails() ?? CONST.EMPTY_OBJECT;
85+
const personalDetails = usePersonalDetails();
8686
const policy = usePolicy(report?.policyID);
87-
const delegatePersonalDetails = personalDetails[action?.delegateAccountID ?? ''];
87+
const delegatePersonalDetails = personalDetails?.[action?.delegateAccountID ?? ''];
8888
const ownerAccountID = iouReport?.ownerAccountID ?? action?.childOwnerAccountID;
8989
const isReportPreviewAction = action?.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW;
9090
const actorAccountID = ReportUtils.getReportActionActorAccountID(action, iouReport, report);
9191
const [invoiceReceiverPolicy] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${report?.invoiceReceiver && 'policyID' in report.invoiceReceiver ? report.invoiceReceiver.policyID : -1}`);
9292

9393
let displayName = ReportUtils.getDisplayNameForParticipant(actorAccountID);
94-
const {avatar, login, pendingFields, status, fallbackIcon} = personalDetails[actorAccountID ?? -1] ?? {};
94+
const {avatar, login, pendingFields, status, fallbackIcon} = personalDetails?.[actorAccountID ?? -1] ?? {};
9595
const accountOwnerDetails = getPersonalDetailByEmail(login ?? '');
9696
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
9797
let actorHint = (login || (displayName ?? '')).replace(CONST.REGEX.MERGED_ACCOUNT_PREFIX, '');
@@ -108,7 +108,7 @@ function ReportActionItemSingle({
108108
actorHint = displayName;
109109
avatarSource = ReportUtils.getWorkspaceIcon(report, policy).source;
110110
avatarId = report?.policyID;
111-
} else if (action?.delegateAccountID && personalDetails[action?.delegateAccountID]) {
111+
} else if (action?.delegateAccountID && personalDetails?.[action?.delegateAccountID]) {
112112
displayName = delegatePersonalDetails?.displayName ?? '';
113113
avatarSource = delegatePersonalDetails?.avatar;
114114
avatarId = delegatePersonalDetails?.accountID;

‎src/pages/home/report/ReportActionsList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ function ReportActionsList({
150150
parentReportActionForTransactionThread,
151151
}: ReportActionsListProps) {
152152
const currentUserPersonalDetails = useCurrentUserPersonalDetails();
153-
const personalDetailsList = usePersonalDetails() || CONST.EMPTY_OBJECT;
153+
const personalDetailsList = usePersonalDetails();
154154
const styles = useThemeStyles();
155155
const {translate} = useLocalize();
156156
const {windowHeight} = useWindowDimensions();

‎src/pages/home/report/ReportFooter.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ function ReportFooter({
141141
let assigneeChatReport;
142142
if (mentionWithDomain) {
143143
if (isValidMention) {
144-
assignee = Object.values(allPersonalDetails).find((value) => value?.login === mentionWithDomain) ?? undefined;
144+
assignee = Object.values(allPersonalDetails ?? {}).find((value) => value?.login === mentionWithDomain) ?? undefined;
145145
if (!Object.keys(assignee ?? {}).length) {
146146
const assigneeAccountID = UserUtils.generateAccountID(mentionWithDomain);
147147
const optimisticDataForNewAssignee = Task.setNewOptimisticAssignee(mentionWithDomain, assigneeAccountID);

‎src/pages/iou/request/MoneyRequestAttendeeSelector.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function MoneyRequestAttendeeSelector({attendees = [], onFinish, onAttendeesAdde
5252
const [betas] = useOnyx(ONYXKEYS.BETAS);
5353
const [activePolicyID] = useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID);
5454
const session = useSession();
55-
const isCurrentUserAttendee = attendees.some((attendee) => attendee.accountID === session.accountID);
55+
const isCurrentUserAttendee = attendees.some((attendee) => attendee.accountID === session?.accountID);
5656
const [recentAttendees] = useOnyx(ONYXKEYS.NVP_RECENT_ATTENDEES);
5757
const policy = usePolicy(activePolicyID);
5858
const [isSearchingForReports] = useOnyx(ONYXKEYS.IS_SEARCHING_FOR_REPORTS, {initWithStoredValues: false});

‎src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ function IOURequestStepConfirmation({
5454
isLoadingTransaction,
5555
}: IOURequestStepConfirmationProps) {
5656
const currentUserPersonalDetails = useCurrentUserPersonalDetails();
57-
const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;
57+
const personalDetails = usePersonalDetails();
5858

5959
const [policyDraft] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_DRAFTS}${IOU.getIOURequestPolicyID(transaction, reportDraft)}`);
6060
const [policyReal] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${IOU.getIOURequestPolicyID(transaction, reportReal)}`);

0 commit comments

Comments
 (0)