Skip to content

Commit 131f500

Browse files
authored
Merge pull request #60812 from software-mansion-labs/improve-desktop-nav/fix-passing-policy-id
iOS - Expense Reports - Report page cannot be dismissed by swiping to right
2 parents 220b6af + caf7e03 commit 131f500

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

src/libs/Navigation/AppNavigator/Navigators/SearchFullscreenNavigator.tsx

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
import React from 'react';
2-
import type {PlatformStackNavigationOptions, PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
2+
import useSplitNavigatorScreenOptions from '@libs/Navigation/AppNavigator/useSplitNavigatorScreenOptions';
3+
import Animations from '@libs/Navigation/PlatformStackNavigation/navigationOptions/animation';
4+
import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
35
import type {AuthScreensParamList, SearchFullscreenNavigatorParamList} from '@libs/Navigation/types';
46
import * as SearchQueryUtils from '@libs/SearchQueryUtils';
57
import createSearchFullscreenNavigator from '@navigation/AppNavigator/createSearchFullscreenNavigator';
68
import FreezeWrapper from '@navigation/AppNavigator/FreezeWrapper';
7-
import useRootNavigatorScreenOptions from '@navigation/AppNavigator/useRootNavigatorScreenOptions';
89
import type NAVIGATORS from '@src/NAVIGATORS';
910
import SCREENS from '@src/SCREENS';
1011
import type ReactComponentModule from '@src/types/utils/ReactComponentModule';
@@ -15,25 +16,20 @@ const loadSearchMoneyReportPage = () => require<ReactComponentModule>('@pages/Se
1516
const Stack = createSearchFullscreenNavigator<SearchFullscreenNavigatorParamList>();
1617

1718
function SearchFullscreenNavigator({route}: PlatformStackScreenProps<AuthScreensParamList, typeof NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR>) {
18-
const rootNavigatorScreenOptions = useRootNavigatorScreenOptions();
19-
const searchRootScreenOptions: PlatformStackNavigationOptions = {
20-
...rootNavigatorScreenOptions.fullScreen,
21-
web: {
22-
...rootNavigatorScreenOptions.fullScreen.web,
23-
cardStyleInterpolator: undefined,
24-
},
25-
};
19+
// These options can be used here because the full screen navigator has the same structure as the split navigator in terms of the central screens, but it does not have a sidebar.
20+
const {centralScreen: centralScreenOptions} = useSplitNavigatorScreenOptions();
2621
return (
2722
<FreezeWrapper>
2823
<Stack.Navigator
29-
screenOptions={searchRootScreenOptions}
24+
screenOptions={centralScreenOptions}
3025
defaultCentralScreen={SCREENS.SEARCH.ROOT}
3126
parentRoute={route}
3227
>
3328
<Stack.Screen
3429
name={SCREENS.SEARCH.ROOT}
3530
getComponent={loadSearchPage}
3631
initialParams={{q: SearchQueryUtils.buildSearchQueryString()}}
32+
options={{animation: Animations.NONE}}
3733
/>
3834
<Stack.Screen
3935
name={SCREENS.SEARCH.MONEY_REQUEST_REPORT}

src/libs/Navigation/AppNavigator/useRootNavigatorScreenOptions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ const useRootNavigatorScreenOptions = () => {
8989
cardStyle: {
9090
height: '100%',
9191
},
92-
cardStyleInterpolator: (props: StackCardInterpolationProps) => modalCardStyleInterpolator({props, isFullScreenModal: true, shouldAnimateSidePanel: true}),
92+
cardStyleInterpolator: (props: StackCardInterpolationProps) => modalCardStyleInterpolator({props, isFullScreenModal: true}),
9393
},
9494
},
9595
} satisfies RootNavigatorScreenOptions;

0 commit comments

Comments
 (0)