Merge pull request #61072 from Krishna2323/krishna2323/issue/60793

fix: Expense - Approved expense that has violation is not marked as approved in the expense preview.

Author: MarioExpensify

src/libs/TransactionPreviewUtils.ts

@@ -229,10 +229,6 @@ function getTransactionPreviewTextAndTranslationPaths({
         isPreviewHeaderTextComplete = true;
     }
 
-    if (shouldShowRBR && transaction) {
-        isPreviewHeaderTextComplete = true;
-    }
-
     if (!isPreviewHeaderTextComplete) {
         if (hasViolationsOfTypeNotice && transaction && !isReportApproved({report: iouReport}) && !isSettled(iouReport?.reportID)) {
             previewHeaderText.push(dotSeparator, {translationPath: 'violations.reviewRequired'});

tests/unit/TransactionPreviewUtils.test.ts

@@ -2,6 +2,7 @@ import {buildOptimisticIOUReport, buildOptimisticIOUReportAction} from '@libs/Re
 import {createTransactionPreviewConditionals, getTransactionPreviewTextAndTranslationPaths} from '@libs/TransactionPreviewUtils';
 import {buildOptimisticTransaction} from '@libs/TransactionUtils';
 import CONST from '@src/CONST';
+import * as ReportUtils from '@src/libs/ReportUtils';
 
 const basicProps = {
     iouReport: buildOptimisticIOUReport(123, 234, 1000, '1', 'USD'),
@@ -118,6 +119,18 @@ describe('TransactionPreviewUtils', () => {
             const result = getTransactionPreviewTextAndTranslationPaths(functionArgs);
             expect(result.previewHeaderText).toContainEqual({translationPath: 'iou.canceled'});
         });
+
+        it('should include "Approved" in the preview when the report is approved, regardless of whether RBR is shown', () => {
+            const functionArgs = {
+                ...basicProps,
+                iouReport: {...basicProps.iouReport, stateNum: CONST.REPORT.STATE_NUM.APPROVED, statusNum: CONST.REPORT.STATUS_NUM.APPROVED},
+                shouldShowRBR: true,
+            };
+            jest.spyOn(ReportUtils, 'isPaidGroupPolicyExpenseReport').mockReturnValue(true);
+            const result = getTransactionPreviewTextAndTranslationPaths(functionArgs);
+
+            expect(result.previewHeaderText).toContainEqual({translationPath: 'iou.approved'});
+        });
     });
 
     describe('createTransactionPreviewConditionals', () => {