Skip to content

Commit 08561a5

Browse files
Sophist-UKEvilGremlin
authored andcommitted
🚸 Move About / Games to menu bottom (MarlinFirmware#26820)
1 parent 951ccb9 commit 08561a5

File tree

1 file changed

+25
-31
lines changed

1 file changed

+25
-31
lines changed

Marlin/src/lcd/menu/menu_main.cpp

Lines changed: 25 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -234,16 +234,6 @@ void menu_configuration();
234234

235235
#endif // CUSTOM_MENU_MAIN
236236

237-
#if ENABLED(ADVANCED_PAUSE_FEATURE)
238-
// This menu item is last with an encoder. Otherwise, somewhere in the middle.
239-
#if E_STEPPERS == 1 && DISABLED(FILAMENT_LOAD_UNLOAD_GCODES)
240-
#define FILAMENT_CHANGE_ITEM() YESNO_ITEM(MSG_FILAMENTCHANGE, menu_change_filament, nullptr, \
241-
GET_TEXT_F(MSG_FILAMENTCHANGE), (const char *)nullptr, F("?"))
242-
#else
243-
#define FILAMENT_CHANGE_ITEM() SUBMENU(MSG_FILAMENTCHANGE, menu_change_filament)
244-
#endif
245-
#endif
246-
247237
void menu_main() {
248238
const bool busy = printingIsActive();
249239
#if HAS_MEDIA
@@ -348,7 +338,11 @@ void menu_main() {
348338
#endif
349339

350340
#if ENABLED(ADVANCED_PAUSE_FEATURE)
351-
FILAMENT_CHANGE_ITEM();
341+
#if E_STEPPERS == 1 && DISABLED(FILAMENT_LOAD_UNLOAD_GCODES)
342+
YESNO_ITEM(MSG_FILAMENTCHANGE, menu_change_filament, nullptr, GET_TEXT_F(MSG_FILAMENTCHANGE), (const char *)nullptr, F("?"));
343+
#else
344+
SUBMENU(MSG_FILAMENTCHANGE, menu_change_filament);
345+
#endif
352346
#endif
353347

354348
#if HAS_TEMPERATURE
@@ -381,10 +375,6 @@ void menu_main() {
381375
}
382376
#endif
383377

384-
#if ENABLED(LCD_INFO_MENU)
385-
SUBMENU(MSG_INFO_MENU, menu_info);
386-
#endif
387-
388378
#if ENABLED(LED_CONTROL_MENU)
389379
SUBMENU(MSG_LIGHTS, menu_led);
390380
#elif ALL(CASE_LIGHT_MENU, CASELIGHT_USES_BRIGHTNESS)
@@ -412,7 +402,6 @@ void menu_main() {
412402
#endif
413403

414404
#if HAS_MEDIA && DISABLED(MEDIA_MENU_AT_TOP)
415-
// BEGIN MEDIA MENU
416405
if (card_detected) {
417406
if (!card_open) {
418407
#if ENABLED(MENU_ADDAUTOSTART)
@@ -449,7 +438,6 @@ void menu_main() {
449438
#endif
450439
#endif
451440
}
452-
// END MEDIA MENU
453441
#endif
454442

455443
#if HAS_SERVICE_INTERVALS
@@ -482,7 +470,26 @@ void menu_main() {
482470
#endif
483471
#endif
484472

485-
#if HAS_GAMES && DISABLED(LCD_INFO_MENU)
473+
#if HAS_MULTI_LANGUAGE
474+
SUBMENU(LANGUAGE, menu_language);
475+
#endif
476+
477+
#if ENABLED(HOST_SHUTDOWN_MENU_ITEM) && defined(SHUTDOWN_ACTION)
478+
SUBMENU(MSG_HOST_SHUTDOWN, []{
479+
MenuItem_confirm::select_screen(
480+
GET_TEXT_F(MSG_BUTTON_PROCEED), GET_TEXT_F(MSG_BUTTON_CANCEL),
481+
[]{ ui.return_to_status(); hostui.shutdown(); }, nullptr,
482+
GET_TEXT_F(MSG_HOST_SHUTDOWN), (const char *)nullptr, F("?")
483+
);
484+
});
485+
#endif
486+
487+
#if ENABLED(LCD_INFO_MENU)
488+
489+
SUBMENU(MSG_INFO_MENU, menu_info);
490+
491+
#elif HAS_GAMES
492+
486493
#if ENABLED(GAMES_EASTER_EGG)
487494
SKIP_ITEM();
488495
SKIP_ITEM();
@@ -504,20 +511,7 @@ void menu_main() {
504511
#endif
505512
);
506513
}
507-
#endif
508514

509-
#if HAS_MULTI_LANGUAGE
510-
SUBMENU(LANGUAGE, menu_language);
511-
#endif
512-
513-
#if ENABLED(HOST_SHUTDOWN_MENU_ITEM) && defined(SHUTDOWN_ACTION)
514-
SUBMENU(MSG_HOST_SHUTDOWN, []{
515-
MenuItem_confirm::select_screen(
516-
GET_TEXT_F(MSG_BUTTON_PROCEED), GET_TEXT_F(MSG_BUTTON_CANCEL),
517-
[]{ ui.return_to_status(); hostui.shutdown(); }, nullptr,
518-
GET_TEXT_F(MSG_HOST_SHUTDOWN), (const char *)nullptr, F("?")
519-
);
520-
});
521515
#endif
522516

523517
END_MENU();

0 commit comments

Comments
 (0)