feat(flow, flow-item)!: avoids removing flow-items from the DOM and adds selected property #9390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removing them from the DOM. #5072
github-actions
bot
added
the
enhancement
driskull
changed the title
driskull
changed the title
driskull
added
the
pr ready for visual snapshots
driskull
changed the title
# Conflicts: # packages/calcite-components/src/components/flow-item/flow-item.stories.ts # packages/calcite-components/src/components/flow/flow.stories.ts
alisonailea
approved these changes
Jun 4, 2024
# Conflicts: # packages/calcite-components/src/components/flow-item/flow-item.stories.ts
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
# Conflicts: # packages/calcite-components/src/components.d.ts # packages/calcite-components/src/components/flow-item/flow-item.stories.ts # packages/calcite-components/src/components/link/readme.md # packages/calcite-components/src/demos/flow.html
driskull
added
the
breaking change
github-actions
bot
removed
the
Stale
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
github-actions
bot
removed
the
Stale
# Conflicts: # packages/calcite-components/src/components.d.ts
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
github-actions
bot
removed
the
Stale
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
github-actions
bot
removed
the
Stale
jcfranco
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Other than a couple of comments, this LGTM!
Can you move the BREAKING CHANGE footer to the end of the description? It needs to be placed at the bottom to adhere to the conventional commits spec:
<type>[optional scope]: <description>
[optional body]
[optional footer(s)]
This can be merged after the Oct milestone wraps up.
| const allowRetreatingDirection = oldFlowItemCount > 1; | ||
| const allowAdvancingDirection = oldFlowItemCount && newFlowItemCount > 1; | ||
| resetFlowDirection = (): void => { | ||
| if (this.el.hasAttribute("data-test-disable-animation-reset")) { |
There was a problem hiding this comment.
Can you add this under a Build.isTesting block (see example) so that it doesn't get included in production builds?
|
When you get a chance, could you help me update this custom flow-item codepen for future reference? |
|
@jcfranco here's an updated codepen: https://codepen.io/driskull/pen/gOVzLbx |
driskull
added
the
pr ready for visual snapshots
driskull
added
pr ready for visual snapshots
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
…dds selected property (#9390) **Related Issue:** #5072 ## Summary - Add `selected` property to `calcite-flow-item`. - Sets the last `calcite-flow-item` as `selected` if no other is `selected. - Requires custom classes implementing `FlowItemLikeElement` to have a `selected` property - Cleans up animation by removing class after animation is complete - update tests - update demo and add placeholder image (the url is slow) - update stories BREAKING CHANGE: The new `selected` property on `calcite-flow-item` must be used to define which `calcite-flow-item` is shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5072
Summary
selectedproperty tocalcite-flow-item.calcite-flow-itemasselectedif no other is `selected.FlowItemLikeElementto have aselectedpropertyBREAKING CHANGE: The new
selectedproperty oncalcite-flow-itemmust be used to define whichcalcite-flow-itemis shown.