Skip to content

fix(navigation-logo): no longer changes icon color when href is parsed #8830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Feb 23, 2024

Related Issue: #8482

Summary

Fixes change of icon color in navigation-logo when href attribute is parsed.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 23, 2024
@anveshmekala anveshmekala added low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 23, 2024
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 23, 2024
@anveshmekala anveshmekala removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 23, 2024
@anveshmekala anveshmekala changed the title fix(navigation-logo): no longer changes icon color when href is parsed fix(navigation-logo): no longer changes icon color when href is parsed Feb 23, 2024
@anveshmekala anveshmekala marked this pull request as ready for review February 23, 2024 22:47
@anveshmekala anveshmekala requested a review from a team as a code owner February 23, 2024 22:47
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 23, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anveshmekala anveshmekala merged commit 16d456f into main Feb 23, 2024
@anveshmekala anveshmekala deleted the anveshmekala/8482-fix-navigation-icon-color-when-href-added branch February 23, 2024 23:40
geospatialem pushed a commit that referenced this pull request Feb 27, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.6.0</summary>

##
[2.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-02-27)


### Features

* **card-group:** Add Card Group component
([#8749](#8749))
([b012324](b012324))
* **tile-group:** Add Tile Group component
([#8806](#8806))
([4f65bdd](4f65bdd))


### Bug Fixes

* **combobox:** Long text truncates on single and single-persist modes
([#8731](#8731))
([8fc42b1](8fc42b1))
* **navigation-logo:** No longer changes icon color when `href` is
parsed
([#8830](#8830))
([16d456f](16d456f))
* Only show validation message when status='invalid'
([#8649](#8649))
([7eac8d7](7eac8d7))
* **preset:** Calcite—color-brand to calcite-color-brand
([#8809](#8809))
([ee2cf4e](ee2cf4e))
* **table:** Ensure border are correctly applied with complex rowSpan
([#8779](#8779))
([69f05d4](69f05d4))
</details>

<details><summary>@esri/calcite-components-angular: 2.6.0</summary>

##
[2.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-02-27)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.6.0-next.3 to ^2.6.0
</details>

<details><summary>@esri/calcite-components-react: 2.6.0</summary>

##
[2.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-02-27)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.6.0-next.3 to ^2.6.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants