Skip to content

[filter] Add a property that doesn't match filter inputs #8753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 6 tasks
sagewall opened this issue Feb 14, 2024 · 5 comments
Closed
2 of 6 tasks

[filter] Add a property that doesn't match filter inputs #8753

sagewall opened this issue Feb 14, 2024 · 5 comments
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review.

Comments

@sagewall
Copy link

Check existing issues

Description

Adding a new unique identifier property possibly named uid to the list-item component. This new property doesn't get matched when filtering the list. This would allow for assigning unique id's to list items and not have to worry about unexpected results appearing in the list after filtering.

Acceptance Criteria

A new property that doesn't get matched for filtering.

Relevant Info

We are currently appending unique identifiers into the value property but they are being matched by the filter leading to unexpected list items remaining in the list after filtering.

Which Component

list-item

Example Use Case

Adding unique identifiers to layers, tables and bookmarks in the ArcGIS Maps SDK for JavaScript LayerList, BasemapLayerList, TableList and Bookmarks widgets.

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript

@sagewall sagewall added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Feb 14, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. p3 - want for upcoming milestone labels Feb 14, 2024
@driskull
Copy link
Member

This would actually be for the filter component.

The filter component has an items property where you can specify the list of items to be filtered as an object.

The issue is that everything within that object is used to filter data. So you can't really add a unique identifier to that object that isn't filtered. Because the filter just spits out the same object its difficult to identity and map the object to its original item.

We would propose a new API which allows for adding a unique identifier to that object that is not counted as filter data.

@driskull driskull changed the title [list-item] Add a property that doesn't match filter inputs [filter] Add a property that doesn't match filter inputs Feb 14, 2024
@sagewall
Copy link
Author

sagewall commented May 13, 2024

@geospatialem is there any way to get this implemented for the JS SDK's 4.31 fall release?

@jcfranco
Copy link
Member

We would propose a new API which allows for adding a unique identifier to that object that is not counted as filter data.

Would #5063 help achieve this?

@driskull
Copy link
Member

Yeah I think that would suffice.

@jcfranco
Copy link
Member

Awesome, thanks for confirming. Closing in favor of #5063.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants