Skip to content

fix(input-time-picker): allow en-us and other supported lowercase locale codes #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 26, 2023
Merged

fix(input-time-picker): allow en-us and other supported lowercase locale codes #7038

merged 4 commits into from
May 26, 2023

Conversation

eriklharper
Copy link
Contributor

Related Issue: #7036

Summary

This fixes an issue where passing in en-us instead of en-US (or inheriting the lang from the HTML tag) was blocking rendering and throwing a console error.

@eriklharper eriklharper requested a review from a team as a code owner May 25, 2023 22:58
@eriklharper eriklharper self-assigned this May 25, 2023
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 25, 2023
@eriklharper eriklharper added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 25, 2023
@eriklharper eriklharper requested a review from benelan May 25, 2023 23:08
driskull
driskull approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good but I think we can make the code more efficient with some kind of function that will format the effectiveLocale to a format we need to work with. The code added seems a little redundant.

jcfranco
jcfranco approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

Please add a new test before merging.

@eriklharper eriklharper changed the title fix(input-time-picker): allow lowercase locale codes fix(input-time-picker): allow en-us and other supported lowercase locale codes May 26, 2023
@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 26, 2023
@eriklharper eriklharper merged commit 3fdee43 into master May 26, 2023
@eriklharper eriklharper deleted the eriklharper/7036-input-time-picker-lowercase-lang-bug branch May 26, 2023 18:06
@github-actions github-actions bot added this to the 1.4.1 May patch - Bugs only milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@driskull driskull driskull approved these changes

@benelan benelan Awaiting requested review from benelan

Assignees

@eriklharper eriklharper

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
1.4.1 May patch - Bugs only
Development

Successfully merging this pull request may close these issues.
3 participants
@eriklharper @jcfranco @driskull