Skip to content

fix: ensure mouse events are blocked only when components are disabled #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented May 25, 2023

Related Issue: #7022

Summary

This updates interactive.ts to prevent blocking of mouse/pointer events unnecessarily. This is needed if mouse/pointer events happen right after toggling disabled on an interactive component.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 25, 2023
@jcfranco jcfranco marked this pull request as ready for review May 25, 2023 18:00
@jcfranco jcfranco requested a review from a team as a code owner May 25, 2023 18:00
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label May 25, 2023
@jcfranco jcfranco merged commit 308ccda into master May 25, 2023
@jcfranco jcfranco deleted the jcfranco/7022-ensure-bubbling-events-are-blocked-only-when-disabled branch May 25, 2023 19:01
@github-actions github-actions bot added this to the 1.4.1 May patch - Bugs only milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants