Skip to content

fix(navigation-logo, navigation-user): Prevent inheriting line-height #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2023
Merged

fix(navigation-logo, navigation-user): Prevent inheriting line-height #7011

merged 3 commits into from
May 24, 2023

Conversation

macandcheese
Copy link
Contributor

Related Issue: #7010

Summary

This more explicitly sets the line height within our components, adds class name where we were targeting elements previously, and does a bit of clean up of related css.

Before (with css from JSAPI 4.27 - this wasn't an issue with 4.26 or prior):

Screen Shot 2023-05-23 at 7 06 56 PM

After:
Screen Shot 2023-05-23 at 7 06 08 PM

@macandcheese macandcheese requested a review from a team as a code owner May 24, 2023 02:14
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 24, 2023
@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels May 24, 2023
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 24, 2023
jcfranco
jcfranco approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 📏🚫

Is this already covered by screenshot tests? If not, could you add one before merging?

@macandcheese
Copy link
Contributor Author

Awesome! 📏🚫

Is this already covered by screenshot tests? If not, could you add one before merging?

We do have the various states in a few tests, but it wouldn't have caught this from the external css. I'll add another with the description and username strings in the main Navigation one though for better coverage.

Separately, maybe we can update the theme story to have a few more components and include a variant that loads the latest JSAPI CSS, so we could have a chance at catching components that allow styles to leak in.

@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 24, 2023
@macandcheese macandcheese merged commit e8cb96b into master May 24, 2023
@macandcheese macandcheese deleted the macandcheese/fix-nav-line-height branch May 24, 2023 16:34
@github-actions github-actions bot added this to the 1.4.1 May patch - Bugs only milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@driskull driskull driskull approved these changes

Assignees

@macandcheese macandcheese

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
1.4.1 May patch - Bugs only
Development

Successfully merging this pull request may close these issues.
3 participants
@macandcheese @jcfranco @driskull