fix(menu): ensure role type is compatible with Stencil's HTMLAttributes interface #6993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
skip visual snapshots
jcfranco
deleted the
jcfranco/make-internal-role-prop-optional-to-match-html-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7000
Summary
This fixes a TS error caused by
roleprop type not matching Stencil'sHTMLAttributes.Went with the
globalAttributesapproach because makingroleoptional would fix the error in a strict-compilation context, but would cause the prerender build to fail with the same error.Worth noting that this also adds support for specifying default
globalAttributesfor initial rendering.