Skip to content

feat(styles): Add additional animation classes #6928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2023

Conversation

macandcheese
Copy link
Contributor

Summary

Adding additional "left" and "right" animation classes, to support #6919 and other future needs.

  • Adds calcite-animate__in-left and calcite-animate__in-right classes.
  • Updates demo page with new classes, and updates demo page "Reset" button functionality.
  • Q - I am imagining for now components will set the correct animation where needed based on rtl. Not sure if there's a better way to make these rtl / ltr supportive with the classes themselves.

@macandcheese macandcheese requested a review from a team as a code owner May 6, 2023 00:47
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label May 6, 2023
@macandcheese macandcheese requested a review from driskull May 6, 2023 00:47
@macandcheese macandcheese added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 6, 2023
@macandcheese macandcheese merged commit 7b2b62e into master May 6, 2023
@macandcheese macandcheese deleted the macandcheese/feat-add-animations branch May 6, 2023 16:34
@github-actions github-actions bot added this to the 2023 May Priorities milestone May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants