fix(input-time-picker): implement dialog behavior to improve a11y #6837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
reviewed
Apr 24, 2023
jcfranco
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
LGTM! Can you add a t9n test to input-time-picker.e2e.ts? You may have to skip it if it fails consistently as stated here.
Elijbet
added
the
pr ready for visual snapshots
jcfranco
reviewed
Apr 24, 2023
geospatialem
modified the milestones:
2023 May Priorities ,
2023 April Priorities - No breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6835
Summary
Updates
input-time-pickerto use the dialog role for its time-picker popover along with descriptive text.