feat(input-time-picker): add focus trap support #6834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elijbet
changed the title
jcfranco
reviewed
Apr 24, 2023
github-actions
bot
added
the
enhancement
jcfranco
deleted the
elijbet/6833-add-focus-trap-to-input-time-picker-popover
branch
|
@eriklharper Can you give this a look as well and LMK if you spot anything? I can address any comments in a follow-up issue/PR. |
geospatialem
modified the milestones:
2023 May Priorities ,
2023 April Priorities - No breaking changes
This looks really good, nothing jumps out at me as weird. Nice work! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue: #6833
Summary
Adds
focus-traptotime-pickerdialog to improve a11y.