feat(input-time-picker): allow toggling time picker by clicking the input or entering the down/escape key #6832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nput or entering the down key
github-actions
bot
added
the
enhancement
jcfranco
reviewed
Apr 24, 2023
eriklharper
reviewed
Apr 24, 2023
Comment on lines
+388
to
+395
| it("does not open the time picker on input keyboard focus", async () => { | ||
| const popover = await page.find("calcite-input-time-picker >>> calcite-popover"); | ||
|
|
||
| await page.keyboard.press("Tab"); | ||
| await page.waitForChanges(); | ||
|
|
||
| expect(await popover.getProperty("open")).not.toBe(true); | ||
| }); |
There was a problem hiding this comment.
This is cool and more inline with how Chrome's native time input works. This will also setup users to expect the focus to be more on the input than in the popup, which will transition usage nicely over to the popover-less input-time component.
There was a problem hiding this comment.
Awesome! Thanks for the note.
jcfranco
added
the
pr ready for visual snapshots
jcfranco
deleted the
elijbet/6830-improve-input-time-picker-toggling-options
branch
github-actions
bot
added this to the
2023 April Priorities - No breaking changes milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6830
Summary
This enhances the
input-time-pickerto allow it to be toggled via mouse and keyboard vs initial focus.