Skip to content

fix(dropdown): trigger should break words when overflowing container. #6747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

driskull
Copy link
Member

@driskull driskull commented Apr 6, 2023

Related Issue: #5903

Summary

Applies css word break to the container of the trigger slotted element. If it overflows its bounds, words will be broken.

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 6, 2023
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Apr 6, 2023
@driskull driskull marked this pull request as ready for review April 6, 2023 23:29
@driskull driskull requested a review from a team as a code owner April 6, 2023 23:29
Copy link
Contributor

@Elijbet Elijbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Per update here lets merge it as a temporary solution until the other more advanced one lands: #5903 (comment) Thanks @driskull :)

@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 10, 2023
@driskull driskull merged commit 496ce7e into master Apr 10, 2023
@driskull driskull deleted the dris0000/dropdown-word-break branch April 10, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants