Skip to content

feat(action-bar, action-pad): Set layout property on child action-group elements. #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 7, 2023

Conversation

driskull
Copy link
Member

@driskull driskull commented Apr 5, 2023

Related Issue: #6390

Summary

Deprecates the layout property on the action-group element. The parent component of the child action-group elements will set the layout property.

…n-group elements. #6390

Deprecates the layout property on the `action-group` element.
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Apr 5, 2023
@driskull driskull marked this pull request as ready for review April 6, 2023 18:13
@driskull driskull requested a review from a team as a code owner April 6, 2023 18:13
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 6, 2023
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a great QoL improvement, thanks!

driskull added a commit that referenced this pull request Apr 6, 2023
Parent components will set the layout for the action-bar.
driskull added a commit that referenced this pull request Apr 6, 2023
@driskull driskull removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 6, 2023
@driskull driskull changed the title feat(action-bar, action-pad, action-group): Set layout on child action-group elements feat(action-bar, action-pad): Set layout property on child action-group elements. Apr 6, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jcfranco
Copy link
Member

jcfranco commented Apr 7, 2023

Forgot to mention, can you update the PR title to include the deprecation? We want these type of changes to show up in the changelog as well.

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 7, 2023
@driskull driskull merged commit 8eefa12 into master Apr 7, 2023
@driskull driskull deleted the dris000/action-group-layout-changes-6390 branch April 7, 2023 16:26
driskull added a commit that referenced this pull request Apr 7, 2023
…ed action-bar components. (#6745)

**Related Issue:** #6739

## Summary

`shell-panel`, and `shell-center-row` components will set the `layout`
property for slotted `action-bar` components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants