Skip to content

fix(accordion, accordion-item): now wraps long words in header (title & description) #6608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Mar 15, 2023

Related Issue: #5683

Summary

The accordion-item header longer title/description no longer extends outside the container instead of wrapping.

Note: Tailwind's break-words implements the overflow-wrap: break-word CSS property, but it seems to have no impact for me in Chrome. Used our word-break() mixin instead to achieve the desired effect.

Provided a _TestOnly screenshot that simulates long words with underscores.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Mar 15, 2023
@Elijbet Elijbet marked this pull request as ready for review March 15, 2023 22:10
@Elijbet Elijbet requested a review from a team as a code owner March 15, 2023 22:10
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Mar 15, 2023
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️ 👍

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@benelan benelan merged commit 46575ff into master Mar 16, 2023
@benelan benelan deleted the elijbet/5683-accordioin-item-longer-title-wraps branch March 16, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants