fix(tooltip): prevent closing of Esc-key-closing parent components when dismissing a tooltip with Esc #6343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parent components that also close with Esc
github-actions
bot
added
the
bug
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
jcfranco
added
the
pr ready for visual snapshots
jcfranco
deleted the
jcfranco/6292-cancel-handled-escape-key-in-tooltips
branch
github-actions
bot
added this to the
2023 February Priorities - No breaking changes milestone
geospatialem
modified the milestones:
2023 February Priorities - 1.1.0 - No breaking changes ,
1.0.6 patch (February 2023) - Bugs only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6292
Summary
This updates tooltip manager to cancel the Esc key press if handled to prevent closing parent components that also close with Esc.
Additionally, extracts a utility to get the tooltip's effective reference element.