Skip to content

fix(input, input-number): increment/decrement to the min/max when value is below/above #6207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2022
Merged

fix(input, input-number): increment/decrement to the min/max when value is below/above #6207

merged 2 commits into from
Dec 30, 2022

Conversation

benelan
Copy link
Member

@benelan benelan commented Dec 29, 2022

Related Issue: #6201

Summary

Follows the native input's behavior by incrementing/decrementing to the min/max property when value is below/above

@benelan benelan requested a review from a team as a code owner December 29, 2022 23:24
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 29, 2022
driskull
driskull approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 👏

@benelan benelan added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 29, 2022
@benelan benelan merged commit d9eb215 into master Dec 30, 2022
@benelan benelan deleted the benelan/6201-input-max-deincrement branch December 30, 2022 21:17
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@benelan benelan

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@benelan @driskull