Skip to content

fix(panel): fix --calcite-panel-header-action-text-color-press #12110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented May 7, 2025

Related Issue: #12104

Summary

Fixes typo preventing pressed action background color prop from applying.

Note: adds test coverage for other CSS props

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 7, 2025
@jcfranco jcfranco marked this pull request as draft May 7, 2025 20:31
@jcfranco jcfranco changed the title fix(panel): fix hover/press header action CSS props fix(panel): fix --calcite-panel-header-action-text-color-press May 7, 2025
@jcfranco jcfranco marked this pull request as ready for review May 7, 2025 23:06
Copy link
Contributor

@aPreciado88 aPreciado88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

Copy link
Contributor

@matgalla matgalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 8, 2025
@jcfranco jcfranco merged commit c47743d into dev May 8, 2025
25 checks passed
@jcfranco jcfranco deleted the jcfranco/12104-fix-panel-header-action-stateful-tokens branch May 8, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants