fix(semantic-tokens): provide sufficient warning color contrast across components #11994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
aPreciado88
added
the
pr ready for visual snapshots
|
Visual changes look g2g! 🚀 |
jcfranco
added
pr ready for visual snapshots
jcfranco
approved these changes
Apr 18, 2025
|
@SkyeSeitz Can you please take a look at the latest snapshots? |
New snapshots look good to me! |
aPreciado88
deleted the
matgalla/7798-rating-ensure-graphical-objects-contrast
branch
benelan
added a commit
that referenced
this pull request
Apr 21, 2025
* origin/dev: (56 commits) feat(button): enhance component's interactivity states (#12005) chore: release next feat: add image display order web component icons (#11992) chore: release next fix(list-item): align elements to the left of the item's content (#11977) chore: release next fix(input, input-number, input-text, text-area, combobox): pass AA for placeholder text color (#11972) docs: update list of contributors (#11997) chore: release next fix(semantic-tokens): provide sufficient warning color contrast across components (#11994) chore: release next feat(tokens): update core neutral color values (#11993) docs: update list of contributors (#11988) chore: release next build(deps): update nx monorepo to v20.8.0 (#11986) build(deps): update arcgis to ^4.32.14 (#11931) chore: add design-tokens as dev dependency for Lerna updates (#11990) build(deps): update dependency @tokens-studio/sd-transforms to v1.3.0 (#11985) feat(tokens): add transparency-inverse tokens (#11974) chore: release next ...
benelan
pushed a commit
that referenced
this pull request
May 14, 2025
…s components (#11994) **Related Issue:** [#7798](#7798) ## Summary Update the following semantic tokens to resolve contrast issues: LIGHT MODE status/warning/default → `color/high-saturation/orange-yellow/h-oy-060` status/warning/hover → `color/vibrant/orange-yellow/v-oy-180` status/warning/press → `color/high-saturation/orange-yellow/h-oy-080` DARK MODE status/warning/default → `color/high-saturation/orange-yellow/h-oy-060` status/warning/hover → `color/vibrant/orange-yellow/v-oy-120` status/warning/press → `color/vibrant/orange-yellow/v-oy-140` --------- Co-authored-by: Matt Gallagher <[email protected]> Co-authored-by: JC Franco <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7798
Summary
Update the following semantic tokens to resolve contrast issues:
LIGHT MODE
status/warning/default →
color/high-saturation/orange-yellow/h-oy-060status/warning/hover →
color/vibrant/orange-yellow/v-oy-180status/warning/press →
color/high-saturation/orange-yellow/h-oy-080DARK MODE
status/warning/default →
color/high-saturation/orange-yellow/h-oy-060status/warning/hover →
color/vibrant/orange-yellow/v-oy-120status/warning/press →
color/vibrant/orange-yellow/v-oy-140