Skip to content

feat(tokens): update core neutral color values #11993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

feat(tokens): update core neutral color values #11993

merged 2 commits into from
Apr 18, 2025

Conversation

matgalla
Copy link
Contributor

@matgalla matgalla commented Apr 18, 2025 •
edited
Loading

Related Issue: #11725
cc @trailtraveler

Summary

This updates 15 of the core.color.neutral token values. Calcite does currently reference most of these tokens in the semantic colors, but the changes are so subtle that no changes to components are anticipated.

Before/after comparisons:
image

Checklist:

  • update --calcite-color-neutral-blk-005 to #F7F7F7
  • update --calcite-color-neutral-blk-010 to #F2F2F2
  • update --calcite-color-neutral-blk-020 to #EBEBEB
  • update --calcite-color-neutral-blk-030 to #DEDEDE
  • update --calcite-color-neutral-blk-050 to #C9C9C9
  • update --calcite-color-neutral-blk-080 to #ABABAB
  • update --calcite-color-neutral-blk-090 to #9E9E9E
  • update --calcite-color-neutral-blk-140 to #6B6B6B
  • update --calcite-color-neutral-blk-150 to #616161
  • update --calcite-color-neutral-blk-160 to #545454
  • update --calcite-color-neutral-blk-190 to #363636
  • update --calcite-color-neutral-blk-210 to #212121
  • update --calcite-color-neutral-blk-220 to #141414
  • update --calcite-color-neutral-blk-230 to #0A0A0A
  • update --calcite-color-neutral-blk-235 to #050505

@matgalla matgalla added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. labels Apr 18, 2025
@matgalla matgalla added this to the 2025-04-29 - Apr Milestone milestone Apr 18, 2025
@matgalla matgalla requested a review from jcfranco April 18, 2025 19:02
@matgalla matgalla self-assigned this Apr 18, 2025
@matgalla matgalla added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 18, 2025
@jcfranco jcfranco added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 18, 2025
@matgalla matgalla added enhancement Issues tied to a new feature or request. and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels Apr 18, 2025
@matgalla matgalla changed the title fix(tokens): update core neutral color values feat(tokens): update core neutral color values Apr 18, 2025
@jcfranco jcfranco marked this pull request as ready for review April 18, 2025 19:49
@jcfranco jcfranco requested a review from alisonailea as a code owner April 18, 2025 19:49
@matgalla matgalla merged commit 9888ca7 into dev Apr 18, 2025
18 checks passed
@matgalla matgalla deleted the matgalla/update-core-blk-token-values branch April 18, 2025 20:13
benelan added a commit that referenced this pull request Apr 21, 2025
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/bump-node
b5d02c6 
* origin/dev: (56 commits)
  feat(button): enhance component's interactivity states (#12005)
  chore: release next
  feat: add image display order web component icons (#11992)
  chore: release next
  fix(list-item): align elements to the left of the item's content (#11977)
  chore: release next
  fix(input, input-number, input-text, text-area, combobox): pass AA for placeholder text color (#11972)
  docs: update list of contributors (#11997)
  chore: release next
  fix(semantic-tokens): provide sufficient warning color contrast across components (#11994)
  chore: release next
  feat(tokens): update core neutral color values (#11993)
  docs: update list of contributors (#11988)
  chore: release next
  build(deps): update nx monorepo to v20.8.0 (#11986)
  build(deps): update arcgis to ^4.32.14 (#11931)
  chore: add design-tokens as dev dependency for Lerna updates (#11990)
  build(deps): update dependency @tokens-studio/sd-transforms to v1.3.0 (#11985)
  feat(tokens): add transparency-inverse tokens (#11974)
  chore: release next
  ...
benelan pushed a commit that referenced this pull request May 14, 2025
@matgalla @jcfranco @benelan
feat(tokens): update core neutral color values (#11993)
46378fa 
**Related Issue:** #11725 
cc @trailtraveler

## Summary
This updates 15 of the `core.color.neutral` token values. Calcite does
currently reference most of these tokens in the `semantic` colors, but
the changes are so subtle that no changes to components are anticipated.

Before/after comparisons:

![image](https://github.com/user-attachments/assets/751efdce-8db5-4000-8fbc-8a81bad8bd72)

## Checklist:
- [x] update `--calcite-color-neutral-blk-005` to #F7F7F7
- [x] update `--calcite-color-neutral-blk-010` to #F2F2F2
- [x] update `--calcite-color-neutral-blk-020` to #EBEBEB
- [x] update `--calcite-color-neutral-blk-030` to #DEDEDE
- [x] update `--calcite-color-neutral-blk-050` to #C9C9C9
- [x] update `--calcite-color-neutral-blk-080` to #ABABAB
- [x] update `--calcite-color-neutral-blk-090` to #9E9E9E
- [x] update `--calcite-color-neutral-blk-140` to #6B6B6B
- [x] update `--calcite-color-neutral-blk-150` to #616161
- [x] update `--calcite-color-neutral-blk-160` to #545454
- [x] update `--calcite-color-neutral-blk-190` to #363636
- [x] update `--calcite-color-neutral-blk-210` to #212121
- [x] update `--calcite-color-neutral-blk-220` to #141414
- [x] update `--calcite-color-neutral-blk-230` to #0A0A0A
- [x] update `--calcite-color-neutral-blk-235` to #050505

---------

Co-authored-by: JC Franco <[email protected]>
@calcite-admin calcite-admin mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@alisonailea alisonailea Awaiting requested review from alisonailea

Assignees

@matgalla matgalla

Labels
enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
2025-04-29 - Apr Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matgalla @jcfranco