feat(navigation-logo): enable interactive states only when href is specified #11202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to resolved class value
jcfranco
added
pr ready for visual snapshots
jcfranco
added
the
pr ready for visual snapshots
jcfranco
requested review from
driskull and
macandcheese
and removed request for
macandcheese
macandcheese
approved these changes
Jan 11, 2025
jcfranco
added
skip visual snapshots
jcfranco
deleted the
jcfranco/9139-allow-making-nav-logo-non-actionable
branch
github-actions
bot
added this to the
2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9139, #7078
Summary
This prevents any confusing interaction states from being displayed when the navigation logo has no active link.