fix(autocomplete): handle focusing when item is clicked and reset inputValue on form reset #11099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
changed the title
driskull
commented
Dec 19, 2024
| // Autocomplete | ||
| const autocomplete = document.getElementById("framework"); | ||
| autocomplete.addEventListener("calciteAutocompleteChange", (event) => { | ||
| autocomplete.inputValue = event.target.value; |
There was a problem hiding this comment.
This is for demonstration purposes only. We don't update the inputValue when a value has been selected. This is because we don't know what data would be best to put into the input. A value may be a unique id, a description or label may be better. Its best to leave this up to the end user to decide if they want to populate the input or not. In some cases, it may be best to leave the input as is with whatever the user has typed in so they can adjust their query.
driskull
added
the
no changelog entry
driskull
added
the
skip visual snapshots
github-actions
bot
added this to the
2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
…utValue on form reset (#11099) **Related Issue:** #10044 ## Summary - opens autocomplete when input is clicked - This is useful for when the input is already focused but the autocomplete is closed. - Sets focus and sets `open=false` when `autocomplete-item` is clicked - ensures that the input receives focus after an `autocomplete-item` is clicked - use `enterKeyHint` property JSX - update `onFormReset` to be called after form component logic - This allows us to reset the `inputValue` to the `defaultInputValue` without overriding existing logic - adds autocomplete to validation demo cc @benelan BEGIN_COMMIT_OVERRIDE END_COMMIT_OVERRIDE
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10044
Summary
open=falsewhenautocomplete-itemis clickedautocomplete-itemis clickedenterKeyHintproperty JSXonFormResetto be called after form component logicinputValueto thedefaultInputValuewithout overriding existing logiccc @benelan
BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE