Skip to content

fix(sort-handle): pass scale to handle action #10942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

eriklharper
Copy link
Contributor

Related Issue: #10723

Summary

This update passes sort-handle's scale property down to the handle action component. This corrects the appearance for large scale sort handles used in components like list-item.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 2, 2024
@eriklharper eriklharper added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 2, 2024
Copy link
Contributor

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eriklharper eriklharper merged commit 23ec01b into dev Dec 3, 2024
15 checks passed
@eriklharper eriklharper deleted the eriklharper/10723-sort-handle-scale-in-list branch December 3, 2024 20:31
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 3, 2024
benelan pushed a commit that referenced this pull request Feb 8, 2025
**Related Issue:** #10723

## Summary

This update passes `sort-handle`'s `scale` property down to the handle
`action` component. This corrects the appearance for large scale sort
handles used in components like `list-item`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants