Skip to content

fix(button, dialog, dropdown, notice, select, sheet, shell-panel, split-button): fix width types #10937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(button, dialog, dropdown, notice, select, sheet, shell-panel, split-button): fix width types #10937

merged 1 commit into from
Dec 3, 2024

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Dec 2, 2024 •
edited
Loading

Related Issue: #10934

Summary

Include half in the updated types. Fix width types.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 2, 2024
@jcfranco
Copy link
Member

jcfranco commented Dec 2, 2024

Can you rephrase your PR title to focus on fixing width types instead?

jcfranco
jcfranco approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Can you update the PR title before merging?

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 3, 2024
@Elijbet Elijbet changed the title fix(button, dialog, dropdown, notice, select, sheet, shell-panel, split-button): fix extract util type fix(button, dialog, dropdown, notice, select, sheet, shell-panel, split-button): fix width types Dec 3, 2024
@Elijbet Elijbet merged commit b779cbf into dev Dec 3, 2024
21 checks passed
@Elijbet Elijbet deleted the elijbet/10934-fix-extract-util-type branch December 3, 2024 06:44
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 3, 2024
benelan pushed a commit that referenced this pull request Feb 8, 2025
@Elijbet @benelan
fix(button, dialog, dropdown, notice, select, sheet, shell-panel, spl…
2a4e4e4 
…it-button): fix width types (#10937)

**Related Issue:** #10934

## Summary
Include `half` in the updated types. Fix `width` types.
@calcite-admin calcite-admin mentioned this pull request Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@Elijbet Elijbet

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elijbet @jcfranco