Skip to content

fix(input-time-zone): ensure name-mode displays IANA time zone identifiers #10923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 2, 2024

Related Issue: #8698, #8005

Summary

Updates time zone labels (name-mode) to display IANA identifiers per #8005 (comment).

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 2, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 2, 2024
Copy link
Contributor

@aPreciado88 aPreciado88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ashetland
Copy link
Contributor

@jcfranco We should see some diffs, right? When I open the storybook, I'm having trouble getting some of the Input Time Zone stories to load.

@jcfranco
Copy link
Member Author

jcfranco commented Dec 2, 2024

@ashetland This is the relevant story. Others are affected by a Chromium bug (see #10895).

WRT diffs, this is a recurring issue for a few components. Screenshots seem to be taken before the component fully loads. We’ve tried using the delay parameter, but that doesn't help.

Copy link
Contributor

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcfranco jcfranco merged commit 6425354 into dev Dec 2, 2024
21 checks passed
@jcfranco jcfranco deleted the jcfranco/8698-update-input-time-zone-list-mode-names branch December 2, 2024 18:10
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 2, 2024
benelan pushed a commit that referenced this pull request Feb 8, 2025
…fiers (#10923)

**Related Issue:** #8698, #8005

## Summary

Updates time zone labels (name-mode) to display IANA identifiers per
#8005 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants