fix(alert): add public --calcite-alert-offset-size css token #10872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
aPreciado88
added this to the 2024-11-26 - 3.0.0 Nov Breaking Change Milestone milestone
…ciado88/10520-alert-token-rename
aPreciado88
added
the
pr ready for visual snapshots
|
@aPreciado88 Can you revisit the PR title to mention the prop that was added instead of focusing on exposing an internal prop? |
aPreciado88
changed the title
| @@ -7,12 +7,12 @@ | |||
| * @prop --calcite-alert-background-color: Specifies the component's background color. | |||
| * @prop --calcite-alert-corner-radius: Specifies the component's corner radius. | |||
| * @prop --calcite-alert-shadow: Specifies the component's shadow. | |||
| * @prop --calcite-alert-offset-size: Specifies the component's bottom spacing | |||
There was a problem hiding this comment.
Could we change this description to be a bit more descriptive now that the name is less specific? It may not be bottom spacing - it could be top, top-right, bottom, bottom-left, etc, depending on placement.
There was a problem hiding this comment.
@macandcheese I can update this! What would be a more appropriate description?
There was a problem hiding this comment.
cc @geospatialem / @DitwanP but something like:
"Specifies the component's "placement" offset" or something?
macandcheese
approved these changes
Nov 26, 2024
aPreciado88
added
pr ready for visual snapshots
|
@ashetland @SkyeSeitz Could you please confirm that these are the usual chromatic false positives? |
| @@ -7,12 +7,12 @@ | |||
| * @prop --calcite-alert-background-color: Specifies the component's background color. | |||
| * @prop --calcite-alert-corner-radius: Specifies the component's corner radius. | |||
| * @prop --calcite-alert-shadow: Specifies the component's shadow. | |||
| * @prop --calcite-alert-offset-size: Specifies the component's placement offset. | |||
There was a problem hiding this comment.
+1 for Adam's comment.
WRT the styling, can you add backticks so the prop is displayed in our docs?
Suggested change
| * @prop --calcite-alert-offset-size: Specifies the component's placement offset. | |
| * @prop --calcite-alert-offset-size: Specifies the component's `placement` offset. |
aPreciado88
added
pr ready for visual snapshots
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10520
Summary
Rename internal
--calcite-internal-alert-edge-distancecss token to--calcite-alert-offset-sizeand make it public.