Skip to content

fix(Popover): Popover reopens when trigger is clicked and autoClose = true #10842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(Popover): Popover reopens when trigger is clicked and autoClose = true #10842

merged 1 commit into from
Nov 25, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Nov 22, 2024 •
edited
Loading

Related Issue: #10841

Summary

  • do not deactivate popover when autoClose is true and reference element is clicked.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 22, 2024
@driskull driskull marked this pull request as ready for review November 25, 2024 18:14
@driskull driskull requested a review from jcfranco November 25, 2024 18:14
jcfranco
jcfranco approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can we add a test for this? We can do this in a follow-up issue if needed. cc @geospatialem

@driskull
Copy link
Member Author

We can do this in a follow-up issue if needed.

Yes follow up plz. Can you assign to Eliza?

@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 25, 2024
@geospatialem geospatialem mentioned this pull request Nov 25, 2024
Closed
@driskull driskull merged commit 8ece94f into dev Nov 25, 2024
15 checks passed
@driskull driskull deleted the dris0000/popover-autoclose-fix-10841 branch November 25, 2024 19:05
benelan pushed a commit that referenced this pull request Feb 8, 2025
@driskull @benelan
fix(Popover): Popover reopens when trigger is clicked and autoClose =…
9b309e7 
… true (#10842)

**Related Issue:** #10841

## Summary

- do not deactivate popover when `autoClose` is true and reference
element is clicked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco