fix(input-date-picker): remove hardcoded strings #10741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
changed the title
jcfranco
added
the
skip visual snapshots
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "chooseDate": "Choose date", | |||
| "dateFormat": "Date Format:" | |||
| "dateFormat": "Date Format: {format}" | |||
There was a problem hiding this comment.
We could avoid the {format} literal in messages and do below in JSX. Thoughts?
{messages.dateFormat} {this.localeData?.placeholder)}
There was a problem hiding this comment.
I think we need it in the template so translations can position accordingly.
github-actions
bot
added this to the 2024-11-26 - 3.0.0 Nov Breaking Change Milestone milestone
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7708
Summary
This addresses item 2 from #7708.